This updates the scraper to work with the current version of baseball-reference.com#1
Open
zfurman56 wants to merge 8 commits into
Open
This updates the scraper to work with the current version of baseball-reference.com#1zfurman56 wants to merge 8 commits into
zfurman56 wants to merge 8 commits into
Conversation
Updated brscraper.py Depricated urllib2 library
Co-authored-by: Zach Furman <zach.furman1@gmail.com>
Co-authored-by: Zach Furman <zach.furman1@gmail.com>
Co-authored-by: Zach Furman <zach.furman1@gmail.com>
Use urllib instead of deprecated urllib2 library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was previously an issue where the scraper would drop the first row of the table body because it's now a
<th>, rather than a<tb>, causing the outputted dictionary keys to be mismatched with incorrect values. For instance, just try the example in the README, and it'll give you an ERA of 30, rather than the actual ERA of 2.89. This fixes that problem by including the<th>tag in the row searching process.It also switches away from the deprecated function
has_key, and instead useshas_attr.