Skip to content

Commit d89a6f5

Browse files
committed
fix(package-manager): remove manual shell quoting from args after shell:false migration
When shell:true was active, arguments with special characters required manual quoting (e.g. `"/Users/gourisankara/.antigravity/antigravity/bin /opt/homebrew/bin /opt/homebrew/sbin /usr/local/bin /System/Cryptexes/App/usr/bin /usr/bin /bin /usr/sbin /sbin /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin /Users/gourisankara/.foundry/bin"`, `--registry="..."`). With shell:false + cmd.exe array invocation, Node.js controls quoting internally — manual quotes are passed as literal characters to the subprocess and cause failures. - ssr-dev-server/index.ts: remove literal quotes around path arg - executor.ts: split --registry="url" into ['--registry', url] Fixes functional regressions identified in #32892 review.
1 parent 799c4c0 commit d89a6f5

File tree

2 files changed

+2
-2
lines changed
  • packages/angular_devkit

2 files changed

+2
-2
lines changed

packages/angular_devkit/build_angular/src/builders/ssr-dev-server/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ function startNodeServer(
231231
const path = join(outputPath, 'main.js');
232232
const env = { ...process.env, PORT: '' + port, NG_ALLOWED_HOSTS: host ?? 'localhost' };
233233

234-
const args = ['--enable-source-maps', `"${path}"`];
234+
const args = ['--enable-source-maps', path];
235235
if (inspectMode) {
236236
args.unshift('--inspect-brk');
237237
}

packages/angular_devkit/schematics/tasks/package-manager/executor.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ export default function (
116116
}
117117

118118
if (factoryOptions.registry) {
119-
args.push(`--registry="${factoryOptions.registry}"`);
119+
args.push('--registry', factoryOptions.registry);
120120
}
121121

122122
if (factoryOptions.force) {

0 commit comments

Comments
 (0)