From 2fb07f51208975dbda1ed92f4ed9ea4fae81c244 Mon Sep 17 00:00:00 2001 From: David Allison <62114487+david-allison@users.noreply.github.com> Date: Mon, 19 Jan 2026 23:27:58 +0000 Subject: [PATCH] fix(browser): SearchView fragment state transitions Previously if opening the 'advanced' search, the content of the 'standard' search overlapped with it This ensures that a tag is used when attaching the 'standard' search so it can be hidden properly Issue 18709 --- .../main/java/com/ichi2/anki/browser/CardBrowserFragment.kt | 5 +++++ .../src/main/res/layout/card_browser_searchview_fragment.xml | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/browser/CardBrowserFragment.kt b/AnkiDroid/src/main/java/com/ichi2/anki/browser/CardBrowserFragment.kt index a46552823096..fb6939fc0084 100644 --- a/AnkiDroid/src/main/java/com/ichi2/anki/browser/CardBrowserFragment.kt +++ b/AnkiDroid/src/main/java/com/ichi2/anki/browser/CardBrowserFragment.kt @@ -249,6 +249,11 @@ class CardBrowserFragment : view.findViewById(R.id.search_view)?.apply { editText.doAfterTextChanged { searchViewModel.onSearchTextChanged(it.toString()) } addTransitionListener { _, _, state -> + if (state == SearchView.TransitionState.SHOWING) { + getOrCreateSearchFragment(StandardSearchFragment.TAG, ::StandardSearchFragment) + return@addTransitionListener + } + if (state != SearchView.TransitionState.HIDDEN) return@addTransitionListener // clear state on hide childFragmentManager diff --git a/AnkiDroid/src/main/res/layout/card_browser_searchview_fragment.xml b/AnkiDroid/src/main/res/layout/card_browser_searchview_fragment.xml index 726dc1f4bc39..5779c63aa751 100644 --- a/AnkiDroid/src/main/res/layout/card_browser_searchview_fragment.xml +++ b/AnkiDroid/src/main/res/layout/card_browser_searchview_fragment.xml @@ -140,7 +140,6 @@ android:id="@+id/search_view_content_container" android:layout_width="match_parent" android:layout_height="match_parent" - android:name="com.ichi2.anki.browser.search.StandardSearchFragment" />