From 959ecb5bf41b6738259fdb47b7093cd3466554af Mon Sep 17 00:00:00 2001 From: anirudh5harma Date: Fri, 26 Jun 2026 17:23:21 +0530 Subject: [PATCH] fix(frontend): restore verification commands --- .github/workflows/frontend.yml | 7 +++---- frontend/forge.config.ts | 4 ++-- frontend/package.json | 1 + 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/frontend.yml b/.github/workflows/frontend.yml index e5c1de46..de3da00d 100644 --- a/.github/workflows/frontend.yml +++ b/.github/workflows/frontend.yml @@ -5,10 +5,6 @@ name: Frontend # vitest.config.ts, and the repo had neither until #171) — this job is the # guard against that happening again. # -# Typecheck is intentionally NOT run here yet: forge.config.ts and -# update-electron-app carry pre-existing type errors. Add `npm run typecheck` -# once those are fixed. - on: push: branches: [main] @@ -37,5 +33,8 @@ jobs: - run: npm ci + - name: Typecheck + run: npm run typecheck + - name: Run vitest suite run: npx vitest run diff --git a/frontend/forge.config.ts b/frontend/forge.config.ts index 99c3ab70..14480602 100644 --- a/frontend/forge.config.ts +++ b/frontend/forge.config.ts @@ -1,5 +1,6 @@ import type { ForgeConfig } from "@electron-forge/shared-types"; import { VitePlugin } from "@electron-forge/plugin-vite"; +import type { NotaryToolCredentials } from "@electron/notarize/lib/types"; import MakerNSIS from "./makers/maker-nsis"; const config: ForgeConfig = { @@ -28,9 +29,8 @@ const config: ForgeConfig = { : undefined, osxNotarize: process.env.AO_NOTARY_PROFILE ? ({ - tool: "notarytool", keychainProfile: process.env.AO_NOTARY_PROFILE, - } as unknown as ForgeConfig["packagerConfig"]["osxNotarize"]) + } satisfies NotaryToolCredentials) : process.env.APPLE_ID ? { appleId: process.env.APPLE_ID, diff --git a/frontend/package.json b/frontend/package.json index 12429528..e9ad7a91 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -14,6 +14,7 @@ }, "scripts": { "build:daemon": "node ./scripts/build-daemon.mjs", + "build": "npm run build:daemon && electron-forge package", "dev": "electron-forge start", "dev:web": "VITE_NO_ELECTRON=1 vite --config vite.renderer.config.ts", "prepackage": "npm run build:daemon",