fix out-of-slice read in ArrowFlightJdbcArray.checkBoundaries

Author: Arawoof06

flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/ArrowFlightJdbcArray.java

@@ -90,7 +90,7 @@ public Object getArray(long index, int count) throws SQLException {
   }
 
   private void checkBoundaries(long index, int count) {
-    if (index < 0 || index + count > this.startOffset + this.valuesCount) {
+    if (index < 0 || index + count > this.valuesCount) {
       throw new ArrayIndexOutOfBoundsException();
     }
   }

flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/ArrowFlightJdbcArrayTest.java

@@ -105,6 +105,20 @@ public void testShouldGetArrayWithOffsetsThrowArrayIndexOutOfBoundsException()
         () -> arrowFlightJdbcArray.getArray(0, dataVector.getValueCount() + 1));
   }
 
+  @Test
+  public void testShouldGetArrayWithOffsetsNotReadPastEndOfSlice() throws SQLException {
+    // Array covering elements 5, 6 and 7 of the underlying vector.
+    ArrowFlightJdbcArray arrowFlightJdbcArray = new ArrowFlightJdbcArray(dataVector, 5, 3);
+    assertThrows(ArrayIndexOutOfBoundsException.class, () -> arrowFlightJdbcArray.getArray(1, 3));
+  }
+
+  @Test
+  public void testShouldGetResultSetWithOffsetsNotReadPastEndOfSlice() throws SQLException {
+    ArrowFlightJdbcArray arrowFlightJdbcArray = new ArrowFlightJdbcArray(dataVector, 5, 3);
+    assertThrows(
+        ArrayIndexOutOfBoundsException.class, () -> arrowFlightJdbcArray.getResultSet(1, 3));
+  }
+
   @Test
   public void testShouldGetArrayWithMapNotBeSupported() throws SQLException {
     ArrowFlightJdbcArray arrowFlightJdbcArray =