From 6cf52bc793e4563e0fc10021c77684bd3b7fb2a7 Mon Sep 17 00:00:00 2001 From: Weijun-H Date: Tue, 1 Jul 2025 22:30:32 +0200 Subject: [PATCH 1/2] feat: Add optional serde_json dependency --- parquet-variant/Cargo.toml | 6 +++++- parquet-variant/src/lib.rs | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/parquet-variant/Cargo.toml b/parquet-variant/Cargo.toml index 708b614cf4b7..29f26fc2c03b 100644 --- a/parquet-variant/Cargo.toml +++ b/parquet-variant/Cargo.toml @@ -35,10 +35,14 @@ rust-version = "1.83" [dependencies] arrow-schema = { workspace = true } chrono = { workspace = true } -serde_json = "1.0" +serde_json = { version = "1.0", optional = true } base64 = "0.22" indexmap = "2.10.0" +[features] +default = [] + +serde_json = ["dep:serde_json"] [lib] name = "parquet_variant" diff --git a/parquet-variant/src/lib.rs b/parquet-variant/src/lib.rs index 8ce3008655d4..25022d745c1e 100644 --- a/parquet-variant/src/lib.rs +++ b/parquet-variant/src/lib.rs @@ -33,10 +33,12 @@ mod decoder; mod variant; // TODO: dead code removal mod builder; +#[cfg(feature = "serde_json")] mod to_json; #[allow(dead_code)] mod utils; pub use builder::*; +#[cfg(feature = "serde_json")] pub use to_json::{variant_to_json, variant_to_json_string, variant_to_json_value}; pub use variant::*; From 003806ec115fd4fc1c40c8bf56552d3d384674df Mon Sep 17 00:00:00 2001 From: Weijun-H Date: Tue, 1 Jul 2025 22:33:23 +0200 Subject: [PATCH 2/2] chore: Update GitHub Actions workflow for parquet-variant --- .github/workflows/parquet-variant.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/parquet-variant.yml b/.github/workflows/parquet-variant.yml index 6fc5c3a8cd00..3c3733d0006f 100644 --- a/.github/workflows/parquet-variant.yml +++ b/.github/workflows/parquet-variant.yml @@ -46,8 +46,11 @@ jobs: submodules: true - name: Setup Rust toolchain uses: ./.github/actions/setup-builder - - name: Test + + - name: Test parquet-variant run: cargo test -p parquet-variant + - name: Test parquet-variant with all features + run: cargo test -p parquet-variant --all-features # test compilation linux-features: