Grey out dynamic scale VM flag on Edit VM dialog if dynamic scaling is not enabled on template, service offering and global setting.

Author: harikrishna-patnala

api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java

@@ -89,7 +89,7 @@ public class UpdateVMCmd extends BaseCustomIdCmd implements SecurityGroupAction,
 
     @Parameter(name = ApiConstants.IS_DYNAMICALLY_SCALABLE,
                type = CommandType.BOOLEAN,
-               description = "true if VM contains XS/VMWare tools inorder to support dynamic scaling of VM cpu/memory")
+               description = "true if VM contains XS/VMWare tools inorder to support dynamic scaling of VM cpu/memory. This can be updated only when dynamic scaling is enabled on template, service offering and the corresponding global setting")
     protected Boolean isDynamicallyScalable;
 
     @Parameter(name = ApiConstants.NAME, type = CommandType.STRING, description = "new host name of the vm. The VM has to be stopped/started for this update to take affect", since = "4.4")

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

@@ -2782,13 +2782,14 @@ public UserVm updateVirtualMachine(long id, String displayName, String group, Bo
             if (isDynamicallyScalable == true) {
                 VMTemplateVO template = _templateDao.findByIdIncludingRemoved(vm.getTemplateId());
                 if (!template.isDynamicallyScalable()) {
-                    throw new InvalidParameterValueException("Dynamic Scaling cannot be enabled on the VM since template is not dynamic scaling enabled");
+                    throw new InvalidParameterValueException("Dynamic Scaling cannot be enabled for the VM since its template does not have dynamic scaling enabled");
                 }
                 if (!offering.isDynamicScalingEnabled()) {
-                    throw new InvalidParameterValueException("Dynamic Scaling cannot be enabled on the VM since service offering is not dynamic scaling enabled");
+                    throw new InvalidParameterValueException("Dynamic Scaling cannot be enabled for the VM since its service offering does not have dynamic scaling enabled");
                 }
                 if (!UserVmManager.EnableDynamicallyScaleVm.valueIn(vm.getDataCenterId())) {
-                    throw new InvalidParameterValueException("Dynamic Scaling cannot be enabled on the VM since corresponding global setting is false");
+                    s_logger.debug(String.format("Dynamic Scaling cannot be enabled for the VM %s since the global setting enable.dynamic.scale.vm is set to false", vm.getUuid()));
+                    throw new InvalidParameterValueException("Dynamic Scaling cannot be enabled for the VM since corresponding global setting is set to false");
                 }
             }
         }

ui/public/locales/en.json

@@ -811,7 +811,7 @@
 "label.driver": "Driver",
 "label.duration.in.sec": "Duration (in sec)",
 "label.dynamicscalingenabled": "Dynamic Scaling Enabled",
-"label.dynamicscalingenabled.tooltip": "VM can dynamically scale only when dynamic scalability is enabled on template, service offering and global setting",
+"label.dynamicscalingenabled.tooltip": "VM can dynamically scale only when dynamic scaling is enabled on template, service offering and global setting",
 "label.edit": "Edit",
 "label.edit.acl.list": "Edit ACL List",
 "label.edit.acl.rule": "Edit ACL rule",

ui/src/views/compute/EditVM.vue

@@ -72,7 +72,8 @@
         </span>
         <a-switch
           :default-checked="resource.isdynamicallyscalable"
-          v-decorator="['isdynamicallyscalable']" />
+          v-decorator="['isdynamicallyscalable']"
+          :disabled="!canDynamicScalingEnabled()" />
       </a-form-item>
       <a-form-item>
         <span slot="label">
@@ -125,6 +126,9 @@ export default {
   },
   data () {
     return {
+      serviceOffering: {},
+      template: {},
+      dynamicScalingVmConfig: false,
       loading: false,
       osTypes: {
         loading: false,
@@ -151,6 +155,44 @@ export default {
     fetchData () {
       this.fetchOsTypes()
       this.fetchInstaceGroups()
+      this.fetchServiceOfferingData()
+      this.fetchTemplateData()
+      this.fetchDynamicScalingVmConfig()
+    },
+    fetchServiceOfferingData () {
+      const params = {}
+      params.id = this.resource.serviceofferingid
+      params.isrecursive = true
+      var apiName = 'listServiceOfferings'
+      api(apiName, params).then(json => {
+        const offerings = json.listserviceofferingsresponse.serviceoffering
+        this.serviceOffering = offerings[0]
+      })
+    },
+    fetchTemplateData () {
+      const params = {}
+      console.log('templateid ' + this.resource.templateid)
+      params.id = this.resource.templateid
+      params.isrecursive = true
+      params.templatefilter = 'all'
+      var apiName = 'listTemplates'
+      api(apiName, params).then(json => {
+        const templateResponses = json.listtemplatesresponse.template
+        this.template = templateResponses[0]
+      })
+    },
+    fetchDynamicScalingVmConfig () {
+      const params = {}
+      params.name = 'enable.dynamic.scale.vm'
+      params.zoneid = this.resource.zoneid
+      var apiName = 'listConfigurations'
+      api(apiName, params).then(json => {
+        const configResponse = json.listconfigurationsresponse.configuration
+        this.dynamicScalingVmConfig = configResponse[0]?.value === 'true'
+      })
+    },
+    canDynamicScalingEnabled () {
+      return this.template.isdynamicallyscalable && this.serviceOffering.dynamicscalingenabled && this.dynamicScalingVmConfig
     },
     fetchOsTypes () {
       this.osTypes.loading = true