Added new response parameter “supportsStorageSnapshot” (true/false) to volume response, and Updated UI to hide the async backup option while taking snapshot for volume(s) with storage snapshot support.

Author: sureshanaparti

api/src/main/java/org/apache/cloudstack/api/ApiConstants.java

@@ -339,6 +339,7 @@ public class ApiConstants {
     public static final String SNAPSHOT_POLICY_ID = "snapshotpolicyid";
     public static final String SNAPSHOT_TYPE = "snapshottype";
     public static final String SNAPSHOT_QUIESCEVM = "quiescevm";
+    public static final String SUPPORTS_STORAGE_SNAPSHOT = "supportsstoragesnapshot";
     public static final String SOURCE_ZONE_ID = "sourcezoneid";
     public static final String START_DATE = "startdate";
     public static final String START_ID = "startid";

api/src/main/java/org/apache/cloudstack/api/response/VolumeResponse.java

@@ -248,8 +248,12 @@ public class VolumeResponse extends BaseResponseWithTagInformation implements Co
     @Param(description = "need quiesce vm or not when taking snapshot", since = "4.3")
     private boolean needQuiescevm;
 
+    @SerializedName(ApiConstants.SUPPORTS_STORAGE_SNAPSHOT)
+    @Param(description = "true if storage snapshot is supported for the volume, false otherwise", since = "4.16")
+    private boolean supportsStorageSnapshot;
+
     @SerializedName(ApiConstants.PHYSICAL_SIZE)
-    @Param(description = "the bytes alloaated")
+    @Param(description = "the bytes allocated")
     private Long physicalsize;
 
     @SerializedName(ApiConstants.VIRTUAL_SIZE)
@@ -538,6 +542,14 @@ public boolean isNeedQuiescevm() {
         return this.needQuiescevm;
     }
 
+    public void setSupportsStorageSnapshot(boolean supportsStorageSnapshot) {
+        this.supportsStorageSnapshot = supportsStorageSnapshot;
+    }
+
+    public boolean getSupportsStorageSnapshot() {
+        return this.supportsStorageSnapshot;
+    }
+
     public String getIsoId() {
         return isoId;
     }

server/src/main/java/com/cloud/api/query/QueryManagerImpl.java

@@ -1901,6 +1901,9 @@ public ListResponse<VolumeResponse> searchForVolumes(ListVolumesCmd cmd) {
             if (caps != null) {
                 boolean quiescevm = Boolean.parseBoolean(caps.get(DataStoreCapabilities.VOLUME_SNAPSHOT_QUIESCEVM.toString()));
                 vr.setNeedQuiescevm(quiescevm);
+
+                boolean supportsStorageSnapshot = Boolean.parseBoolean(caps.get(DataStoreCapabilities.STORAGE_SYSTEM_SNAPSHOT.toString()));
+                vr.setSupportsStorageSnapshot(supportsStorageSnapshot);
             }
         }
         response.setResponses(volumeResponses, result.second());

ui/src/views/compute/CreateSnapshotWizard.vue

@@ -64,7 +64,7 @@
           </span>
           <a-switch v-decorator="['quiescevm', { initialValue: false }]"/>
         </a-form-item>
-        <a-form-item>
+        <a-form-item v-if="!supportsStorageSnapshot">
           <span slot="label" :title="apiParams.asyncbackup.description">
             {{ $t('label.asyncbackup') }}
             <a-tooltip>
@@ -97,6 +97,7 @@ export default {
     return {
       loading: false,
       isQuiesceVm: false,
+      supportsStorageSnapshot: false,
       listVolumes: []
     }
   },
@@ -131,7 +132,10 @@ export default {
         const params = {}
         params.volumeid = values.volumeid
         params.name = values.name
-        params.asyncbackup = values.asyncbackup
+        params.asyncbackup = false
+        if (values.asyncbackup) {
+          params.asyncbackup = values.asyncbackup
+        }
         params.quiescevm = values.quiescevm
 
         const title = this.$t('label.action.vmstoragesnapshot.create')
@@ -176,6 +180,7 @@ export default {
       const volumeFilter = this.listVolumes.filter(volume => volume.id === volumeId)
       if (volumeFilter && volumeFilter.length > 0) {
         this.isQuiesceVm = volumeFilter[0].quiescevm
+        this.supportsStorageSnapshot = volumeFilter[0].supportsstoragesnapshot
       }
     },
     closeAction () {

ui/src/views/storage/TakeSnapshot.vue

@@ -34,7 +34,7 @@
                 :placeholder="apiParams.name.description" />
             </a-form-item>
           </a-col>
-          <a-col :md="24" :lg="24">
+          <a-col :md="24" :lg="24" v-if="!supportsStorageSnapshot">
             <a-form-item :label="$t('label.asyncbackup')">
               <a-switch v-decorator="['asyncbackup']" />
             </a-form-item>
@@ -113,6 +113,7 @@ export default {
     return {
       actionLoading: false,
       quiescevm: false,
+      supportsStorageSnapshot: false,
       inputValue: '',
       inputKey: '',
       inputVisible: '',
@@ -130,6 +131,7 @@ export default {
   },
   mounted () {
     this.quiescevm = this.resource.quiescevm
+    this.supportsStorageSnapshot = this.resource.supportsstoragesnapshot
   },
   methods: {
     handleSubmit (e) {