server: rethrow takeVMSnapshot() exception instead of returning null (#3546)

onitake · yadvr · commit 29e1bbc22d5f · 2019-12-08T03:49:54.000+05:30
Fixes NPE, and throws actual exception with the error stacktrace Fixes: #3518
diff --git a/server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java b/server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
@@ -515,7 +515,7 @@ private VMSnapshot orchestrateCreateVMSnapshot(Long vmId, Long vmSnapshotId, Boo
             return snapshot;
         } catch (Exception e) {
             s_logger.debug("Failed to create vm snapshot: " + vmSnapshotId, e);
-            return null;
+            throw new CloudRuntimeException("Failed to create vm snapshot: " + vmSnapshotId, e);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -515,7 +515,7 @@ private VMSnapshot orchestrateCreateVMSnapshot(Long vmId, Long vmSnapshotId, Boo`
`515`	`515`	`return snapshot;`
`516`	`516`	`} catch (Exception e) {`
`517`	`517`	`s_logger.debug("Failed to create vm snapshot: " + vmSnapshotId, e);`
`518`		`- return null;`
	`518`	`+ throw new CloudRuntimeException("Failed to create vm snapshot: " + vmSnapshotId, e);`
`519`	`519`	`}`
`520`	`520`	`}`
`521`	`521`