Skip to content

Commit 2b1c4fb

Browse files
authored
.github: fix workflow settings and allow branch pushes to main by committers (#6225)
This fixes the comment message for merge conflict checker and resets the github branch protection for main in case of need by the RM. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
1 parent 1500e1f commit 2b1c4fb

2 files changed

Lines changed: 3 additions & 10 deletions

File tree

.asf.yaml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,4 @@ github:
4646
collaborators:
4747
- acs-robot
4848

49-
#protected_branches:
50-
# main:
51-
# required_pull_request_reviews:
52-
# required_approving_review_count: 2
49+
protected_branches: ~

.github/workflows/merge-conflict-checker.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,8 @@
1818
name: "Check Pull Requests Conflict"
1919
on:
2020
push:
21-
branches:
22-
- main
23-
pull_request:
21+
pull_request_target:
2422
types: [synchronize]
25-
branches:
26-
- main
2723

2824
jobs:
2925
triage:
@@ -36,4 +32,4 @@ jobs:
3632
dirtyLabel: "status:has-conflicts"
3733
removeOnDirtyLabel: "status:ready-for-review"
3834
continueOnMissingPermissions: true
39-
commentOnDirty: "Hi @${author}, your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch?"
35+
commentOnDirty: "Hi @${{ github.event.pull_request.user.login }}, your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch?"

0 commit comments

Comments
 (0)