Skip to content

Commit 4fd7291

Browse files
committed
CE-113 removed TODOs
1 parent 8065aed commit 4fd7291

2 files changed

Lines changed: 0 additions & 4 deletions

File tree

engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotServiceImpl.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -282,9 +282,6 @@ public SnapshotInfo backupSnapshot(SnapshotInfo snapshot) {
282282
try {
283283
SnapshotResult res = future.get();
284284
if (res.isFailed()) {
285-
// TODO add cleanup actions in this case
286-
// TODO think of whether a runtime exception is really what we want]
287-
288285
throw new CloudRuntimeException(res.getResult());
289286
}
290287
SnapshotInfo destSnapshot = res.getSnapshot();

engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1995,7 +1995,6 @@ public SnapshotInfo takeSnapshot(VolumeInfo volume) {
19951995
snapshot = snapshotMgr.takeSnapshot(volume);
19961996
} catch (CloudRuntimeException cre) {
19971997
s_logger.error("Take snapshot: " + volume.getId() + " failed", cre);
1998-
// TODO deal with cleaning the mess
19991998
throw cre;
20001999
} catch (Exception e) {
20012000
if(s_logger.isDebugEnabled()) {

0 commit comments

Comments
 (0)