Merge release branch 4.13 to master

* 4.13:
  vr: fix password server run with empty gateway in isolated netw… (#3943)
  Fix simulator docker db deploy issue (#3397) (#3651)

Author: DaanHoogland

systemvm/debian/opt/cloud/bin/cs/CsAddress.py

@@ -583,9 +583,9 @@ def post_config_change(self, method):
                         CsPasswdSvc(self.address['public_ip']).stop()
                 elif cmdline.is_master():
                     if method == "add":
-                        CsPasswdSvc(self.address['gateway'] + "," + self.address['public_ip']).start()
+                        CsPasswdSvc(self.get_gateway() + "," + self.address['public_ip']).start()
                     elif method == "delete":
-                        CsPasswdSvc(self.address['gateway'] + "," + self.address['public_ip']).stop()
+                        CsPasswdSvc(self.get_gateway() + "," + self.address['public_ip']).stop()
 
         if self.get_type() == "public" and self.config.is_vpc() and method == "add":
             if self.address["source_nat"]:

tools/docker/Dockerfile

@@ -22,6 +22,8 @@ FROM ubuntu:16.04
 MAINTAINER "Apache CloudStack" <dev@cloudstack.apache.org>
 LABEL Vendor="Apache.org" License="ApacheV2" Version="4.14.0.0-SNAPSHOT"
 
+ARG DEBIAN_FRONTEND=noninteractive
+
 RUN apt-get -y update && apt-get install -y \
     genisoimage \
     libffi-dev \
@@ -37,32 +39,29 @@ RUN apt-get -y update && apt-get install -y \
     python-mysql.connector \
     supervisor
 
-RUN echo 'mysql-server mysql-server/root_password password root' |  debconf-set-selections; \
-    echo 'mysql-server mysql-server/root_password_again password root' |  debconf-set-selections;
-
 RUN apt-get install -qqy mysql-server && \
     apt-get clean all && \
     mkdir /var/run/mysqld; \
     chown mysql /var/run/mysqld
 
 RUN echo '''sql_mode = "STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION"''' >> /etc/mysql/mysql.conf.d/mysqld.cnf
-RUN (/usr/bin/mysqld_safe &); sleep 5; mysqladmin -u root -proot password ''
-
-#RUN pip install --allow-external mysql-connector-python mysql-connector-python
 
 COPY tools/docker/supervisord.conf /etc/supervisor/conf.d/supervisord.conf
 COPY . ./root
 WORKDIR /root
 
 RUN mvn -Pdeveloper -Dsimulator -DskipTests clean install
 
-RUN (/usr/bin/mysqld_safe &); \
+RUN find /var/lib/mysql -type f -exec touch {} \; && \
+    (/usr/bin/mysqld_safe &) && \
     sleep 5; \
     mvn -Pdeveloper -pl developer -Ddeploydb; \
     mvn -Pdeveloper -pl developer -Ddeploydb-simulator; \
     MARVIN_FILE=`find /root/tools/marvin/dist/ -name "Marvin*.tar.gz"`; \
     pip install $MARVIN_FILE
 
+VOLUME /var/lib/mysql
+
 EXPOSE 8080 8096
 
 CMD ["/usr/bin/supervisord"]