Skip to content

Commit 72f967a

Browse files
committed
test(backup): mock BackupDetailsDao to fix NPE in NASBackupProviderTest
Adds @mock injection for BackupDetailsDao so NASBackupProvider's backupDetailsDao field is wired during testDeleteBackup and takeBackupSuccessfully, fixing the NPE flagged by @harikrishna-patnala.
1 parent 9764025 commit 72f967a

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

plugins/backup/nas/src/test/java/org/apache/cloudstack/backup/NASBackupProviderTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@
5252
import com.cloud.vm.dao.VMInstanceDao;
5353

5454
import org.apache.cloudstack.backup.dao.BackupDao;
55+
import org.apache.cloudstack.backup.dao.BackupDetailsDao;
5556
import org.apache.cloudstack.backup.dao.BackupRepositoryDao;
5657
import org.apache.cloudstack.backup.dao.BackupOfferingDao;
5758
import org.apache.cloudstack.storage.datastore.db.PrimaryDataStoreDao;
@@ -96,6 +97,9 @@ public class NASBackupProviderTest {
9697
@Mock
9798
private VMSnapshotDao vmSnapshotDaoMock;
9899

100+
@Mock
101+
private BackupDetailsDao backupDetailsDao;
102+
99103
@Test
100104
public void testDeleteBackup() throws OperationTimedoutException, AgentUnavailableException {
101105
Long hostId = 1L;

0 commit comments

Comments
 (0)