Skip to content

Commit 8f12011

Browse files
committed
add log indicating chosen capacityType for ordering
1 parent 339621c commit 8f12011

2 files changed

Lines changed: 14 additions & 0 deletions

File tree

server/src/main/java/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -410,6 +410,7 @@ private Pair<List<Long>, Map<Long, Double>> getOrderedHostsByCapacity(Long zoneI
410410
// Get capacity by which we should reorder
411411
short capacityType = FirstFitPlanner.getHostCapacityTypeToOrderCluster(
412412
_configDao.getValue(Config.HostCapacityTypeToOrderClusters.key()), cpuToMemoryWeight);
413+
logger.debug("CapacityType: {} is used for Host ordering", FirstFitPlanner.getCapacityTypeName(capacityType));
413414
if (capacityType >= 0) { // for CPU or RAM
414415
return _capacityDao.orderHostsByFreeCapacity(zoneId, clusterId, capacityType);
415416
}

server/src/main/java/com/cloud/deploy/FirstFitPlanner.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -518,6 +518,8 @@ private Pair<List<Long>, Map<Long, Double>> getOrderedPodsByCapacity(long zoneId
518518
double cpuToMemoryWeight = ConfigurationManager.HostCapacityTypeCpuMemoryWeight.value();
519519
short capacityType = getHostCapacityTypeToOrderCluster(
520520
configDao.getValue(Config.HostCapacityTypeToOrderClusters.key()), cpuToMemoryWeight);
521+
522+
logger.debug("CapacityType: {} is used for Pod ordering", getCapacityTypeName(capacityType));
521523
if (capacityType >= 0) { // for capacityType other than COMBINED
522524
return capacityDao.orderPodsByAggregateCapacity(zoneId, capacityType);
523525
}
@@ -551,6 +553,8 @@ private Pair<List<Long>, Map<Long, Double>> getOrderedClustersByCapacity(long id
551553
double cpuToMemoryWeight = ConfigurationManager.HostCapacityTypeCpuMemoryWeight.value();
552554
short capacityType = getHostCapacityTypeToOrderCluster(
553555
configDao.getValue(Config.HostCapacityTypeToOrderClusters.key()), cpuToMemoryWeight);
556+
557+
logger.debug("CapacityType: {} is used for Cluster ordering", getCapacityTypeName(capacityType));
554558
if (capacityType >= 0) { // for capacityType other than COMBINED
555559
return capacityDao.orderClustersByAggregateCapacity(id, vmId, capacityType, isZone);
556560
}
@@ -564,6 +568,15 @@ private Pair<List<Long>, Map<Long, Double>> getOrderedClustersByCapacity(long id
564568
return new Pair<>(new ArrayList<>(clusterByCombinedCapacities.keySet()), clusterByCombinedCapacities);
565569
}
566570

571+
public static String getCapacityTypeName(short capacityType) {
572+
switch (capacityType) {
573+
case 0: return ApiConstants.RAM;
574+
case 1: return ApiConstants.CPU;
575+
case -1: return ApiConstants.COMBINED_CAPACITY_ORDERING;
576+
default: return "UNKNOWN";
577+
}
578+
}
579+
567580
public Map<Long, Double> getClusterByCombinedCapacities(List<CapacityVO> capacities, double cpuToMemoryWeight) {
568581
Map<Long, Double> clusterByCombinedCapacity = new HashMap<>();
569582
for (CapacityVO capacityVO : capacities) {

0 commit comments

Comments
 (0)