Skip to content

Commit 96cd9d9

Browse files
author
Anurag Awasthi
committed
ui: Make the page title, help URL and about popup configurable
This helps brands in setting up relevant resources in their deployement.
1 parent c68bc10 commit 96cd9d9

5 files changed

Lines changed: 24 additions & 21 deletions

File tree

ui/config.js

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,17 @@
1515
// specific language governing permissions and limitations
1616
// under the License.
1717

18-
// Define Keyboard Options for the UI
19-
var keyboardOptions = {
20-
"us": "label.standard.us.keyboard",
21-
"uk": "label.uk.keyboard",
22-
"fr": "label.french.azerty.keyboard",
23-
"jp": "label.japanese.keyboard",
24-
"sc": "label.simplified.chinese.keyboard"
25-
}
18+
// Define custom options configurable by admins for UI
19+
cloudStackOptions = {
20+
aboutText: "label.app.name",
21+
aboutTitle: "label.about.app",
22+
docTitle: "label.app.name",
23+
helpURL: "http://docs.cloudstack.apache.org/",
24+
keyboardOptions: {
25+
"us": "label.standard.us.keyboard",
26+
"uk": "label.uk.keyboard",
27+
"fr": "label.french.azerty.keyboard",
28+
"jp": "label.japanese.keyboard",
29+
"sc": "label.simplified.chinese.keyboard"
30+
}
31+
};

ui/index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1804,8 +1804,8 @@ <h3><translate key="label.set.up.zone.type"/></h3>
18041804

18051805
// Inject translated keyboard options
18061806
var keyboardDropdown = $($.find('#keyboard-options'));
1807-
for (var key in keyboardOptions) {
1808-
keyboardDropdown.append($('<option>', {value: key, text: translate(keyboardOptions[key])}));
1807+
for (var key in cloudStackOptions.keyboardOptions) {
1808+
keyboardDropdown.append($('<option>', {value: key, text: translate(cloudStackOptions.keyboardOptions[key])}));
18091809
}
18101810
</script>
18111811

ui/scripts/cloudStack.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -482,6 +482,6 @@
482482

483483
cloudStack.uiCustom.login(loginArgs);
484484

485-
document.title = _l('label.app.name');
485+
document.title = _l(cloudStackOptions.docTitle);
486486
});
487487
})(cloudStack, jQuery);

ui/scripts/templates.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -449,10 +449,10 @@
449449
id: "",
450450
description: ""
451451
});
452-
for (var key in keyboardOptions) {
452+
for (var key in cloudStackOptions.keyboardOptions) {
453453
items.push({
454454
id: key,
455-
description: _l(keyboardOptions[key])
455+
description: _l(cloudStackOptions.keyboardOptions[key])
456456
});
457457
}
458458
args.response.success({

ui/scripts/ui/core.js

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -317,23 +317,20 @@
317317

318318
if (this == 'label.help') {
319319
$link.addClass('help').click(function() {
320-
var helpURL = 'http://cloudstack.apache.org/';
321-
322-
window.open(helpURL, '_blank');
323-
320+
window.open(cloudStackOptions.helpURL, '_blank');
324321
return false;
325322
});
326323
}
327324
if (this == 'label.about') {
328325
$link.addClass('about').click(function() {
329-
var $logo = $('<div>').addClass('logo').text(_l('label.app.name')),
330-
$version = $('<div>').addClass('version').text(g_cloudstackversion),
326+
var $logo = $('<div>').addClass('logo').text(_l(cloudStackOptions.aboutText)),
327+
$version = $('<div>').addClass('version').text(_l(g_cloudstackversion)),
331328
$about = $('<div>').addClass('about').append($logo).append($version);
332-
329+
333330
var $aboutDialog = $about.dialog({
334331
modal: true,
335332
width: 300,
336-
title: _l('label.about.app'),
333+
title: _l(cloudStackOptions.aboutTitle),
337334
closeOnEscape: false,
338335
dialogClass: 'dialog-about',
339336
buttons: {

0 commit comments

Comments
 (0)