Skip to content

Commit c60d927

Browse files
committed
Improve logging for template store cleanup by adding debug information for pre-download states
1 parent 3b69432 commit c60d927

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -571,10 +571,13 @@ public void handleTemplateSync(DataStore store) {
571571
&& tmpltStore.getState() == State.Ready
572572
&& tmpltStore.getInstallPath() == null) {
573573
logger.info("Keep fake entry in template store table for migration of previous NFS to object store");
574-
} else {
574+
} else if (tmpltStore.getDownloadState() == VMTemplateStorageResourceAssoc.Status.DOWNLOADED
575+
|| tmpltStore.getState() == State.Ready) {
575576
logger.info("Removing leftover template {} entry from template store table", tmplt);
576-
// remove those leftover entries
577577
_vmTemplateStoreDao.remove(tmpltStore.getId());
578+
} else {
579+
logger.debug("Template {} entry on store {} is in pre-download state ({}/{}); not treating as leftover.",
580+
tmplt, store, tmpltStore.getState(), tmpltStore.getDownloadState());
578581
}
579582
}
580583
}

0 commit comments

Comments
 (0)