[vmware, ssvm] Scale down of ssvm

Author: Pearl1594

engine/components-api/src/main/java/com/cloud/storage/StorageManager.java

@@ -116,6 +116,9 @@ public interface StorageManager extends StorageService {
     ConfigKey<Integer>  SecStorageMaxMigrateSessions = new ConfigKey<Integer>("Advanced", Integer.class, "secstorage.max.migrate.sessions", "2",
             "The max number of concurrent copy command execution sessions that an SSVM can handle", false, ConfigKey.Scope.Global);
 
+    ConfigKey<Boolean>  SecStorageVMScaleDown = new ConfigKey<Boolean>("Advanced", Boolean.class, "secstorage.vm.scale.down", "false",
+            "Setting this to 'true' will allow scaling down the number of SSVMs if the load criteria is met", true, ConfigKey.Scope.Global);
+
     ConfigKey<Integer> MaxDataMigrationWaitTime = new ConfigKey<Integer>("Advanced", Integer.class, "max.data.migration.wait.time", "15",
             "Maximum wait time for a data migration task before spawning a new SSVM", false, ConfigKey.Scope.Global);
 

server/src/main/java/com/cloud/storage/StorageManagerImpl.java

@@ -2959,6 +2959,7 @@ public ConfigKey<?>[] getConfigKeys() {
                 MaxNumberOfManagedClusteredFileSystems,
                 PRIMARY_STORAGE_DOWNLOAD_WAIT,
                 SecStorageMaxMigrateSessions,
+                SecStorageVMScaleDown,
                 MaxDataMigrationWaitTime
         };
     }

services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/PremiumSecondaryStorageManagerImpl.java

@@ -184,7 +184,9 @@ else if (!copyCmdsInPipeline.isEmpty()  && copyCmdsInPipeline.size() >= halfLimi
             return new Pair<AfterScanAction, Object>(AfterScanAction.expand, SecondaryStorageVm.Role.commandExecutor);
 
         }
-        scaleDownSSVMOnLoad(alreadyRunning, activeCmds, copyCmdsInPipeline);
+        if (StorageManager.SecStorageVMScaleDown.value()) {
+            scaleDownSSVMOnLoad(alreadyRunning, activeCmds, copyCmdsInPipeline);
+        }
         return new Pair<AfterScanAction, Object>(AfterScanAction.nop, null);
     }