Externalize strings

Author: joel.tazzari

plugins/user-authenticators/oauth2/src/main/java/org/apache/cloudstack/oauth2/api/command/RegisterOAuthProviderCmd.java

@@ -30,6 +30,7 @@
 import org.apache.cloudstack.context.CallContext;
 import org.apache.cloudstack.oauth2.OAuth2AuthManager;
 import org.apache.cloudstack.oauth2.api.response.OauthProviderResponse;
+import org.apache.cloudstack.oauth2.keycloak.KeycloakOAuth2Provider;
 import org.apache.cloudstack.oauth2.vo.OauthProviderVO;
 import org.apache.commons.collections.MapUtils;
 import org.apache.commons.lang3.StringUtils;
@@ -114,7 +115,7 @@ public Map getDetails() {
 
     @Override
     public void execute() throws ServerApiException, ConcurrentOperationException, EntityExistsException {
-        if (StringUtils.equals("keycloak", getProvider())) {
+        if (StringUtils.equals(KeycloakOAuth2Provider.KEYCLOAK_PROVIDER, getProvider())) {
             if (StringUtils.isBlank(getAuthorizeUrl())) {
                 throw new ServerApiException(ApiErrorCode.BAD_REQUEST, "Parameter authorizeurl is mandatory for keycloak OAuth Provider");
             }

plugins/user-authenticators/oauth2/src/main/java/org/apache/cloudstack/oauth2/keycloak/KeycloakOAuth2Provider.java

@@ -52,6 +52,8 @@
 
 public class KeycloakOAuth2Provider extends AdapterBase implements UserOAuth2Authenticator {
 
+    public static final String KEYCLOAK_PROVIDER = "keycloak";
+
     protected String idToken = null;
 
     @Inject
@@ -69,7 +71,7 @@ public KeycloakOAuth2Provider(CloseableHttpClient httpClient) {
 
     @Override
     public String getName() {
-        return "keycloak";
+        return KEYCLOAK_PROVIDER;
     }
 
     @Override