Skip to content

Commit e9da30b

Browse files
Merge pull request #2456 from rafaelweingartner/CLOUDSTACK-10293
[CLOUDSTACK-10293] Single view network ACL rules listing
2 parents e532b57 + a436426 commit e9da30b

19 files changed

Lines changed: 448 additions & 291 deletions

File tree

ui/css/cloudstack3.css

Lines changed: 48 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8391,7 +8391,6 @@ div.container div.panel div#details-tab-addloadBalancer.detail-group div.loadBal
83918391
border-right: 1px solid #CFC9C9;
83928392
height: 15px;
83938393
overflow: auto;
8394-
padding-right: 0;
83958394
}
83968395

83978396
.multi-edit .data .data-body .data-item > table tbody tr td span {
@@ -8426,8 +8425,44 @@ div.container div.panel div#details-tab-addloadBalancer.detail-group div.loadBal
84268425
color: #0000FF;
84278426
}
84288427

8429-
.multi-edit .data .data-body .data-item table tbody tr td.multi-actions {
8430-
border-right: none;
8428+
div#details-tab-aclRules table.multi-edit tr th.number,
8429+
div#details-tab-aclRules div.data-item table tr td.number {
8430+
width: 45px !important;
8431+
min-width: 45px !important;
8432+
max-width: 45px !important;
8433+
}
8434+
8435+
div#details-tab-aclRules div.multi-edit table tr th.action,
8436+
div#details-tab-aclRules div.multi-edit table tr td.action {
8437+
width: 40px !important;
8438+
min-width: 40px !important;
8439+
max-width: 40px !important;
8440+
}
8441+
8442+
div#details-tab-aclRules div.multi-edit table tr th.protocol,
8443+
div#details-tab-aclRules div.multi-edit table tr td.protocol {
8444+
width: 50px !important;
8445+
min-width: 50px !important;
8446+
max-width: 50px !important;
8447+
}
8448+
8449+
div#details-tab-aclRules div.multi-edit table tr th.protocolnumber,
8450+
div#details-tab-aclRules div.multi-edit table tr td.protocolnumber {
8451+
width: 60px !important;
8452+
min-width: 60px !important;
8453+
max-width: 60px !important;
8454+
}
8455+
8456+
div#details-tab-aclRules div.multi-edit table tr th.startport, div#details-tab-aclRules div.multi-edit table tr td.startport,
8457+
div#details-tab-aclRules div.multi-edit table tr th.endport, div#details-tab-aclRules div.multi-edit table tr td.endport {
8458+
width: 70px !important;
8459+
min-width: 70px !important;
8460+
max-width: 70px !important;
8461+
}
8462+
8463+
div#details-tab-aclRules td.cidrlist span {
8464+
text-align: center;
8465+
width: 100%;
84318466
}
84328467

84338468
.multi-edit .data .data-body .data-item table tbody tr td.multi-actions .action {
@@ -8548,17 +8583,18 @@ div.container div.panel div#details-tab-addloadBalancer.detail-group div.loadBal
85488583

85498584
.detail-view .multi-edit table tr th,
85508585
.detail-view .multi-edit table tr td {
8551-
width: 87px !important;
8552-
min-width: 87px !important;
8553-
max-width: 87px !important;
8586+
width: 84px !important;
8587+
min-width: 84px !important;
8588+
max-width: 84px !important;
85548589
font-size: 10px;
85558590
}
85568591

85578592
/* special case for 'Source CIDR' column - make it wide enough to fit a CIDR without ellipsizing*/
85588593
.detail-view .multi-edit table tr th.cidrlist,
85598594
.detail-view .multi-edit table tr td.cidrlist {
8560-
min-width: 112px !important;
8561-
max-width: 112px !important;
8595+
min-width: 118px !important;
8596+
max-width: 118px !important;
8597+
padding: 0 0 0 0;
85628598
}
85638599
.detail-view .multi-edit td.cidrlist input {
85648600
width: 85%;
@@ -8615,9 +8651,9 @@ div.container div.panel div#details-tab-addloadBalancer.detail-group div.loadBal
86158651
/*Sortable*/
86168652
.multi-edit table tbody tr td.reorder,
86178653
.multi-edit table thead tr th.reorder {
8618-
width: 30px !important;
8619-
min-width: 30px !important;
8620-
max-width: 30px !important;
8654+
width: 16px !important;
8655+
min-width: 16px !important;
8656+
max-width: 16px !important;
86218657
}
86228658

86238659
/*Security Rules*/
@@ -13037,7 +13073,7 @@ div.ui-dialog div.autoscaler div.field-group div.form-container form div.form-it
1303713073
-khtml-border-radius: 10px;
1303813074
border-radius: 10px;
1303913075
border-radius: 10px 10px 10px 10px;
13040-
background-position: -74px -162px;
13076+
background-position: -82px -162px;
1304113077
}
1304213078

1304313079
.moveDrag:hover .icon {
@@ -13357,4 +13393,3 @@ div.panel.copy-template-destination-list div.list-view div.fixed-header{
1335713393
.multi-edit-add-list .ui-button.copytemplatecancel {
1335813394
left: 310px;
1335913395
}
13360-

ui/l10n/ar.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@
1616
// under the License.
1717
var dictionary = {
1818
"ICMP.code": "ICMP Code",
19+
"ICMP.code.desc": "Please specify -1 if you want to allow all ICMP codes",
1920
"ICMP.type": "ICMP Type",
21+
"ICMP.type.desc": "Please specify -1 if you want to allow all ICMP types.",
2022
"changed.item.properties": "تغير خصائص العنصر",
2123
"confirm.enable.s3": "فضلا قم بتعبئة البيانات القادمة لتمكين التخزين S3 للذاكرة الثانوية.",
2224
"confirm.enable.swift": "Please fill in the following information to enable support for Swift",
@@ -367,6 +369,7 @@ var dictionary = {
367369
"label.add.role": "Add Role",
368370
"label.add.route": "إضافة مسار",
369371
"label.add.rule": "إضافة قاعدة",
372+
"label.add.rule.desc": "Create a new ACL rule",
370373
"label.add.secondary.storage": "Add Secondary Storage",
371374
"label.add.security.group": "Add Security Group",
372375
"label.add.service.offering": "Add Service Offering",
@@ -1278,6 +1281,7 @@ var dictionary = {
12781281
"label.projects": "المشاريع",
12791282
"label.protocol": "Protocol",
12801283
"label.protocol.number": "Protocol Number",
1284+
"label.protocol.number.short" : "#Protocol",
12811285
"label.provider": "Provider",
12821286
"label.providers": "Providers",
12831287
"label.public": "Public",
@@ -1427,6 +1431,7 @@ var dictionary = {
14271431
"label.routing": "Routing",
14281432
"label.routing.host": "Routing Host",
14291433
"label.rule": "Rule",
1434+
"label.rule.number.short": "#Rule",
14301435
"label.rule.number": "Rule Number",
14311436
"label.rules": "Rules",
14321437
"label.running.vms": "Running VMs",

ui/l10n/ca.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@
1616
// under the License.
1717
var dictionary = {
1818
"ICMP.code": "ICMP Code",
19+
"ICMP.code.desc": "Please specify -1 if you want to allow all ICMP codes",
1920
"ICMP.type": "ICMP Type",
21+
"ICMP.type.desc": "Please specify -1 if you want to allow all ICMP types.",
2022
"changed.item.properties": "Changed item properties",
2123
"confirm.enable.s3": "Please fill in the following information to enable support for S3-backed Secondary Storage",
2224
"confirm.enable.swift": "Si us plau ompliu la següent informació per habilitar el suport per a Swift",
@@ -367,6 +369,7 @@ var dictionary = {
367369
"label.add.role": "Add Role",
368370
"label.add.route": "Add route",
369371
"label.add.rule": "Afegir regla",
372+
"label.add.rule.desc": "Create a new ACL rule",
370373
"label.add.secondary.storage": "Add Secondary Storage",
371374
"label.add.security.group": "Add Security Group",
372375
"label.add.service.offering": "Add Service Offering",
@@ -1278,6 +1281,7 @@ var dictionary = {
12781281
"label.projects": "Projectes",
12791282
"label.protocol": "Protocol",
12801283
"label.protocol.number": "Protocol Number",
1284+
"label.protocol.number.short" : "#Protocol",
12811285
"label.provider": "Provider",
12821286
"label.providers": "Proveïdors",
12831287
"label.public": "Public",
@@ -1427,6 +1431,7 @@ var dictionary = {
14271431
"label.routing": "Routing",
14281432
"label.routing.host": "Routing Host",
14291433
"label.rule": "Rule",
1434+
"label.rule.number.short": "#Rule",
14301435
"label.rule.number": "Rule Number",
14311436
"label.rules": "Rules",
14321437
"label.running.vms": "Running VMs",

ui/l10n/de_DE.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@
1616
// under the License.
1717
var dictionary = {
1818
"ICMP.code": "ICMP-Code",
19+
"ICMP.code.desc": "Please specify -1 if you want to allow all ICMP codes",
1920
"ICMP.type": "ICMP-Typ",
21+
"ICMP.type.desc": "Please specify -1 if you want to allow all ICMP types.",
2022
"changed.item.properties": "Geänderte Eintragseigenschaften",
2123
"confirm.enable.s3": "Bitte fügen Sie die folgenden Informationen hinzu, um die Unterstützung für \"S3-backed Secondary Storage\" hinzuzufügen",
2224
"confirm.enable.swift": "Bitte fügen Sie die folgenden Informationen hinzu, um die Unterstützung für Swift zu ermöglichen.",
@@ -367,6 +369,7 @@ var dictionary = {
367369
"label.add.role": "Rolle hinzufügen",
368370
"label.add.route": "Route hinzufügen",
369371
"label.add.rule": "Regel hinzufügen",
372+
"label.add.rule.desc": "Create a new ACL rule",
370373
"label.add.secondary.storage": "Sekundärspeicher hinzufügen",
371374
"label.add.security.group": "Sicherheitsgruppe hinzufügen",
372375
"label.add.service.offering": "Dienstangebot hinzufügen",
@@ -1278,6 +1281,7 @@ var dictionary = {
12781281
"label.projects": "Projekte",
12791282
"label.protocol": "Protokoll",
12801283
"label.protocol.number": "Protokollnummer",
1284+
"label.protocol.number.short" : "#Protokoll",
12811285
"label.provider": "Anbieter",
12821286
"label.providers": "Anbieter",
12831287
"label.public": "Öffentlich",
@@ -1427,6 +1431,7 @@ var dictionary = {
14271431
"label.routing": "Routing",
14281432
"label.routing.host": "Routing Host",
14291433
"label.rule": "Regel",
1434+
"label.rule.number.short": "#Regel",
14301435
"label.rule.number": "Regelnummer",
14311436
"label.rules": "Regeln",
14321437
"label.running.vms": "Laufende VMs",

ui/l10n/en.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,11 @@
1414
// KIND, either express or implied. See the License for the
1515
// specific language governing permissions and limitations
1616
// under the License.
17-
var dictionary = {"ICMP.code":"ICMP Code",
17+
var dictionary = {
18+
"ICMP.code":"ICMP Code",
19+
"ICMP.code.desc": "Please specify -1 if you want to allow all ICMP codes",
1820
"ICMP.type":"ICMP Type",
21+
"ICMP.type.desc": "Please specify -1 if you want to allow all ICMP types.",
1922
"changed.item.properties":"Changed item properties",
2023
"confirm.enable.s3":"Please fill in the following information to enable support for S3-backed Secondary Storage",
2124
"confirm.enable.swift":"Please fill in the following information to enable support for Swift",
@@ -370,6 +373,7 @@ var dictionary = {"ICMP.code":"ICMP Code",
370373
"label.add.role":"Add Role",
371374
"label.add.route":"Add route",
372375
"label.add.rule":"Add rule",
376+
"label.add.rule.desc": "Create a new ACL rule",
373377
"label.add.secondary.storage":"Add Secondary Storage",
374378
"label.add.security.group":"Add Security Group",
375379
"label.add.service.offering":"Add Service Offering",
@@ -1316,6 +1320,7 @@ var dictionary = {"ICMP.code":"ICMP Code",
13161320
"label.promiscuous.mode":"Promiscuous Mode",
13171321
"label.protocol":"Protocol",
13181322
"label.protocol.number":"Protocol Number",
1323+
"label.protocol.number.short" : "#Protocol",
13191324
"label.provider":"Provider",
13201325
"label.providers":"Providers",
13211326
"label.public":"Public",
@@ -1467,6 +1472,7 @@ var dictionary = {"ICMP.code":"ICMP Code",
14671472
"label.routing.host":"Routing Host",
14681473
"label.rule":"Rule",
14691474
"label.rule.number":"Rule Number",
1475+
"label.rule.number.short": "#Rule",
14701476
"label.rules":"Rules",
14711477
"label.running.vms":"Running VMs",
14721478
"label.s3.access_key":"Access Key",

ui/l10n/es.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@
1616
// under the License.
1717
var dictionary = {
1818
"ICMP.code": "Código ICMP",
19+
"ICMP.code.desc": "Please specify -1 if you want to allow all ICMP codes",
1920
"ICMP.type": "Tipo ICMP",
21+
"ICMP.type.desc": "Please specify -1 if you want to allow all ICMP types.",
2022
"changed.item.properties": "Cambiadas las propiedades del elemento",
2123
"confirm.enable.s3": "Por favor, complete la siguiente información para habilitar el soporte del Almacenamiento Secundario sobre S3",
2224
"confirm.enable.swift": "Por favor, complete la siguiente información para habilitar el soporte para Swift",
@@ -367,6 +369,7 @@ var dictionary = {
367369
"label.add.role": "Agregar Rol",
368370
"label.add.route": "Agregar ruta",
369371
"label.add.rule": "Agregar regla",
372+
"label.add.rule.desc": "Create a new ACL rule",
370373
"label.add.secondary.storage": "Añadir almacenamiento secundario",
371374
"label.add.security.group": "Agregar grupo de seguridad",
372375
"label.add.service.offering": "Añadir Oferta de Servicio",
@@ -1278,6 +1281,7 @@ var dictionary = {
12781281
"label.projects": "Proyectos",
12791282
"label.protocol": "Protocolo",
12801283
"label.protocol.number": "Número de Protocolo",
1284+
"label.protocol.number.short" : "#Protocolo",
12811285
"label.provider": "Proveedor",
12821286
"label.providers": "Proveedores",
12831287
"label.public": "Pública",
@@ -1427,6 +1431,7 @@ var dictionary = {
14271431
"label.routing": "Enrutamiento",
14281432
"label.routing.host": "Servidor de Routeo",
14291433
"label.rule": "Regla",
1434+
"label.rule.number.short": "#Regla",
14301435
"label.rule.number": "Número de Regla",
14311436
"label.rules": "Reglas",
14321437
"label.running.vms": "MVs corriendo",

ui/l10n/fr_FR.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@
1616
// under the License.
1717
var dictionary = {
1818
"ICMP.code": "Code ICMP",
19+
"ICMP.code.desc": "Please specify -1 if you want to allow all ICMP codes",
1920
"ICMP.type": "Type ICMP",
21+
"ICMP.type.desc": "Please specify -1 if you want to allow all ICMP types.",
2022
"changed.item.properties": "Propriétés de l'élément modifiées",
2123
"confirm.enable.s3": "Remplir les informations suivantes pour activer le support de stockage secondaire S3",
2224
"confirm.enable.swift": "Remplir les informations suivantes pour activer Swift",
@@ -367,6 +369,7 @@ var dictionary = {
367369
"label.add.role": "Ajouter Rôle",
368370
"label.add.route": "Ajouter route",
369371
"label.add.rule": "Ajouter règle",
372+
"label.add.rule.desc": "Create a new ACL rule",
370373
"label.add.secondary.storage": "Ajouter un stockage secondaire",
371374
"label.add.security.group": "Ajouter un groupe de sécurité",
372375
"label.add.service.offering": "Ajouter Offre Service",
@@ -1278,6 +1281,7 @@ var dictionary = {
12781281
"label.projects": "Projets",
12791282
"label.protocol": "Protocole",
12801283
"label.protocol.number": "Numéro Protocole",
1284+
"label.protocol.number.short" : "#Protocole",
12811285
"label.provider": "Fournisseur",
12821286
"label.providers": "Fournisseurs",
12831287
"label.public": "Publique",
@@ -1427,6 +1431,7 @@ var dictionary = {
14271431
"label.routing": "Routage",
14281432
"label.routing.host": "Hôte de routage",
14291433
"label.rule": "Règle",
1434+
"label.rule.number.short": "#Règle",
14301435
"label.rule.number": "Numéro règle",
14311436
"label.rules": "Règles",
14321437
"label.running.vms": "VMs actives",

ui/l10n/hu.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@
1616
// under the License.
1717
var dictionary = {
1818
"ICMP.code": "ICMP kód",
19+
"ICMP.code.desc": "Please specify -1 if you want to allow all ICMP codes",
1920
"ICMP.type": "ICMP típus",
21+
"ICMP.type.desc": "Please specify -1 if you want to allow all ICMP types.",
2022
"changed.item.properties": "Az elem tulajdonságai megváltoztak",
2123
"confirm.enable.s3": "Töltsd ki a következő információkat az S3 másodlagos tár bekapcsolásához!",
2224
"confirm.enable.swift": "Töltsd ki a következő információkat a Swift támogatás bekapcsolásához!",
@@ -367,6 +369,7 @@ var dictionary = {
367369
"label.add.role": "Add Role",
368370
"label.add.route": "Útvonal felvétele",
369371
"label.add.rule": "Szabály felvétele",
372+
"label.add.rule.desc": "Create a new ACL rule",
370373
"label.add.secondary.storage": "Másodlagos tár felvétele",
371374
"label.add.security.group": "Biztonsági csoport felvétele",
372375
"label.add.service.offering": "Szolgáltatás ajánlat felvétele",
@@ -1278,6 +1281,7 @@ var dictionary = {
12781281
"label.projects": "Projektek",
12791282
"label.protocol": "Protokol",
12801283
"label.protocol.number": "Protokoll szám",
1284+
"label.protocol.number.short" : "#Protocol",
12811285
"label.provider": "Szolgáltató",
12821286
"label.providers": "Szolgáltatók",
12831287
"label.public": "Publikus",
@@ -1427,6 +1431,7 @@ var dictionary = {
14271431
"label.routing": "Útvonalválasztás",
14281432
"label.routing.host": "Routing kiszolgáló",
14291433
"label.rule": "Rule",
1434+
"label.rule.number.short": "#Rule",
14301435
"label.rule.number": "Szabály szám",
14311436
"label.rules": "Szabályok",
14321437
"label.running.vms": "Futó VM-ek",

ui/l10n/it_IT.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@
1616
// under the License.
1717
var dictionary = {
1818
"ICMP.code": "Codice ICMP",
19+
"ICMP.code.desc": "Please specify -1 if you want to allow all ICMP codes",
1920
"ICMP.type": "Tipo ICMP",
21+
"ICMP.type.desc": "Please specify -1 if you want to allow all ICMP types.",
2022
"changed.item.properties": "Elementi delle proprietà modificati",
2123
"confirm.enable.s3": "Si prega di inserire i valori richiesti per abilitare il supporto per il Secondary Storage di tipo S3",
2224
"confirm.enable.swift": "Si prega di inserire i valori richiesti per abilitare il supporto per Swift",
@@ -367,6 +369,7 @@ var dictionary = {
367369
"label.add.role": "Add Role",
368370
"label.add.route": "Aggiungere una rotta",
369371
"label.add.rule": "Aggiungere regola",
372+
"label.add.rule.desc": "Create a new ACL rule",
370373
"label.add.secondary.storage": "Aggiungere uno Storage Secondario",
371374
"label.add.security.group": "Aggiungere un Gruppo di Sicurezza",
372375
"label.add.service.offering": "Aggiungere un'Offerta di Servizio",
@@ -1278,6 +1281,7 @@ var dictionary = {
12781281
"label.projects": "Progetti",
12791282
"label.protocol": "Protocol",
12801283
"label.protocol.number": "Protocol Number",
1284+
"label.protocol.number.short" : "#Protocol",
12811285
"label.provider": "Provider",
12821286
"label.providers": "Fornitori",
12831287
"label.public": "Public",
@@ -1427,6 +1431,7 @@ var dictionary = {
14271431
"label.routing": "Routing",
14281432
"label.routing.host": "Routing Host",
14291433
"label.rule": "Rule",
1434+
"label.rule.number.short": "#Rule",
14301435
"label.rule.number": "Rule Number",
14311436
"label.rules": "Regole",
14321437
"label.running.vms": "Running VMs",

0 commit comments

Comments
 (0)