From fc1cc74059e51a0317a678026d8f170d4c12bded Mon Sep 17 00:00:00 2001 From: Wei Zhou Date: Thu, 5 Feb 2026 13:01:41 +0100 Subject: [PATCH 1/3] VR: fix haproxy check when ssl offloading is configured --- systemvm/debian/root/health_checks/haproxy_check.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/systemvm/debian/root/health_checks/haproxy_check.py b/systemvm/debian/root/health_checks/haproxy_check.py index c1db51e440c2..497cc04100e4 100644 --- a/systemvm/debian/root/health_checks/haproxy_check.py +++ b/systemvm/debian/root/health_checks/haproxy_check.py @@ -50,7 +50,7 @@ def checkLoadBalance(haproxyData, haCfgSections): correct = False bindStr = lbSec["sourceIp"] + ":" + formatPort(lbSec["sourcePortStart"], lbSec["sourcePortEnd"]) - if cfgSection["bind"][0] != bindStr: + if not cfgSection["bind"][0].startswith(bindStr): print("Incorrect bind string found. Expected " + bindStr + " but found " + cfgSection["bind"][0] + ".") correct = False From 9a312bd4fca1292e606b1d3fad3ae63874787ad4 Mon Sep 17 00:00:00 2001 From: Wei Zhou Date: Sun, 8 Feb 2026 15:52:07 +0100 Subject: [PATCH 2/3] Update systemvm/debian/root/health_checks/haproxy_check.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- systemvm/debian/root/health_checks/haproxy_check.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/systemvm/debian/root/health_checks/haproxy_check.py b/systemvm/debian/root/health_checks/haproxy_check.py index 497cc04100e4..e3b053b1c831 100644 --- a/systemvm/debian/root/health_checks/haproxy_check.py +++ b/systemvm/debian/root/health_checks/haproxy_check.py @@ -50,7 +50,9 @@ def checkLoadBalance(haproxyData, haCfgSections): correct = False bindStr = lbSec["sourceIp"] + ":" + formatPort(lbSec["sourcePortStart"], lbSec["sourcePortEnd"]) - if not cfgSection["bind"][0].startswith(bindStr): + bind_line = cfgSection["bind"][0] + bind_token = bind_line.split()[0] if bind_line else "" + if bind_token != bindStr: print("Incorrect bind string found. Expected " + bindStr + " but found " + cfgSection["bind"][0] + ".") correct = False From 12ff7a33a3e5a350385badadb55e10dfbf314199 Mon Sep 17 00:00:00 2001 From: Wei Zhou Date: Mon, 11 May 2026 11:54:37 +0200 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: Wei Zhou --- systemvm/debian/root/health_checks/haproxy_check.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/systemvm/debian/root/health_checks/haproxy_check.py b/systemvm/debian/root/health_checks/haproxy_check.py index e3b053b1c831..56a33345ee9f 100644 --- a/systemvm/debian/root/health_checks/haproxy_check.py +++ b/systemvm/debian/root/health_checks/haproxy_check.py @@ -51,8 +51,8 @@ def checkLoadBalance(haproxyData, haCfgSections): bindStr = lbSec["sourceIp"] + ":" + formatPort(lbSec["sourcePortStart"], lbSec["sourcePortEnd"]) bind_line = cfgSection["bind"][0] - bind_token = bind_line.split()[0] if bind_line else "" - if bind_token != bindStr: + bind_token = bind_line.split()[:2] if bind_line else "" + if (" ").join(bind_token) != bindStr: print("Incorrect bind string found. Expected " + bindStr + " but found " + cfgSection["bind"][0] + ".") correct = False