Skip to content

Backport workflow-hardening fix (unpinned-uses) to maint-16.x #23037

@CharlieMCY

Description

@CharlieMCY

Summary

The default branch already hardened .github/workflows/dev.yml against the issue(s) below, but the release branch maint-16.x still carries it. This proposes the same, minimal fix for that branch.

Affected branch / file

  • branch: maint-16.x (HEAD c8d10c56)
  • file: .github/workflows/dev.yml

What's flagged (by zizmor)

  • unpinned-uses — actions referenced by mutable tag/branch instead of a pinned commit SHA

These are already resolved on the default branch in 9b27952 but the fix was not backported to maint-16.x.

Suggested fix

Concretely:

  • ~ jobs.$J.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
  • ~ jobs.$J.steps[uses=korandoru/hawkeye].uses : pin(korandoru/hawkeye -> target_ref SHA)
  • ~ jobs.$J2.steps[uses=actions/checkout].uses : pin(actions/checkout -> target_ref SHA)
  • ~ jobs.$J2.steps[uses=actions/setup-node].uses : pin(actions/setup-node -> target_ref SHA)
--- a/.github/workflows/dev.yml
+++ b/.github/workflows/dev.yml
@@ -36,8 +36,8 @@
     name: Use prettier to check formatting of documents
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744  # v3
+      - uses: actions/setup-node@3235b876344d2a9aa001b8d1453c930bba69e610  # v3
         with:
           node-version: "14"
       - name: Prettier check

(Whitespace is normalized in the diff above; only the security-relevant lines change.) This patch was checked locally with zizmor and actionlint: the flagged finding(s) are cleared on the affected construct and no new lint or security findings are introduced.


This issue was prepared by an automated workflow-hardening analysis and double-checked against the two scanners above. Please review before merging — happy to send a pull request instead if that's preferred.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions