From 1bb1d9a597ba17c9deb1bde2b1b17f816d569114 Mon Sep 17 00:00:00 2001 From: Ankita Victor-Levi Date: Thu, 19 Mar 2026 10:58:35 +0530 Subject: [PATCH] Minor improvements --- .../src/main/java/org/apache/gluten/rexnode/Utils.java | 2 +- .../org/apache/gluten/vectorized/VLVectorIterator.java | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gluten-flink/planner/src/main/java/org/apache/gluten/rexnode/Utils.java b/gluten-flink/planner/src/main/java/org/apache/gluten/rexnode/Utils.java index fea76f5fd4d5..ca8b259e2893 100644 --- a/gluten-flink/planner/src/main/java/org/apache/gluten/rexnode/Utils.java +++ b/gluten-flink/planner/src/main/java/org/apache/gluten/rexnode/Utils.java @@ -84,7 +84,7 @@ public static List analyzeJoinKeys( io.github.zhztheplayer.velox4j.type.RowType inputType, int[] joinKeys, List upsertKeys) { - Set joinKeySet = new HashSet(); + Set joinKeySet = new HashSet<>(joinKeys.length, 1.0f); Arrays.stream(joinKeys).forEach(joinKeySet::add); List uniqueKeysContainedByJoinKey = upsertKeys.stream() diff --git a/gluten-flink/runtime/src/main/java/org/apache/gluten/vectorized/VLVectorIterator.java b/gluten-flink/runtime/src/main/java/org/apache/gluten/vectorized/VLVectorIterator.java index f53376089a39..d99135302ded 100644 --- a/gluten-flink/runtime/src/main/java/org/apache/gluten/vectorized/VLVectorIterator.java +++ b/gluten-flink/runtime/src/main/java/org/apache/gluten/vectorized/VLVectorIterator.java @@ -18,17 +18,17 @@ import io.github.zhztheplayer.velox4j.data.RowVector; +import java.util.ArrayDeque; +import java.util.Deque; import java.util.Iterator; -import java.util.LinkedList; -import java.util.List; /** Iterator for velox RowVector. */ public class VLVectorIterator implements Iterator { - private final List rows; + private final Deque rows; public VLVectorIterator() { - this.rows = new LinkedList<>(); + this.rows = new ArrayDeque<>(); } public boolean hasNext() { @@ -39,7 +39,7 @@ public RowVector next() { if (!hasNext()) { return null; } - return rows.remove(0); + return rows.removeFirst(); } public void addRow(RowVector row) {