-
Notifications
You must be signed in to change notification settings - Fork 724
[Bug][DORA-change_lead_time_calculator] Wrong deployment reference #8790
Description
Search before asking
- I had searched in the issues and found no similar issues.
What happened
Hi so I did do a search to see if there were any issues similar to what I was facing and found the following:
and related
#7193
I was wondering if these issues ever got resolved? I can see that there were two related pull requests but they were closed.
This issue is first set of deployment commits for a project are being wrongly associated to old MRs leading to a massively skewed Median lead time for change.
We had previously got around this using webhook deployments, the single registration of a deployment using webhooks did not lead to the behavior described above.
However we are looking to transition to use the Gitlab connector plugin and annoyingly we are finding the very first merge requests of the project from over a year ago are being associated to the first recorded deployments in devlake.
It would be good to get an update on the above issues which seemed to stale out.
We are using v1.0.2-beta6 and are looking to upgrade to the latest, however not sure if this issue was ever addressed? Please correct me if I am wrong.
What do you expect to happen
From my research I expect that the first deployment is a seed commit deployment in which there is no lead time calculation made.
Then for the subsequent deployment the median lead time for change is calculated for MR commit hashes between the first deployment and the second deployment and so forth.
How to reproduce
Reproduce:
- Onboard a project with historical merge request data but without historical deployment data
- Generate a number of new merge requests with associated deployments
- Run the DORA pipeline on Devlake
- View skewed Median lead time for change results
Anything else
This does not happen when registering deployments via webhooks one at a time.
It does happen when using the Gitlab connector and there are already a group of deployments to be extracted for the first time.
I have tried using a webhook deployment as a 'seed deploy commit' then followed by configuring the gitlab connector but I get the same behavior.
Version
v1.0.2-beta6
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Code of Conduct
- I agree to follow this project's Code of Conduct