[MCHECKSTYLE-456] Checkstyle seems to not print info about skip

[jira-importer]

Matthias Bünger opened MCHECKSTYLE-456 and commented

When checkstyle plugin is skipped via skip-property it looks like the plugin does not tell the user, while other plugins do

[INFO] --- jacoco:0.8.12:prepare-agent-integration (default) @ META-POM ---
[INFO] Skipping JaCoCo execution because property jacoco.skip is set.
[INFO]
[INFO] --- failsafe:3.5.2:integration-test (default) @ META-POM ---
[INFO] Tests are skipped.
[INFO]
[INFO] --- failsafe:3.5.2:verify (default) @ META-POM ---
[INFO] Tests are skipped.
[INFO]
[INFO] --- checkstyle:3.6.0:check (default) @ META-POM ---
[INFO]
[INFO] >>> pmd:3.26.0:check (pmd_check) > :pmd @ META-POM >>>
[INFO]
[INFO] --- pmd:3.26.0:pmd (pmd) @ META-POM ---
[INFO] Skipping org.apache.maven.plugins:maven-pmd-plugin:3.26.0:pmd report goal
[INFO]
[INFO] <<< pmd:3.26.0:check (pmd_check) < :pmd @ META-POM <<<
[INFO]
[INFO]
[INFO] --- pmd:3.26.0:check (pmd_check) @ META-POM ---
[INFO] Skipping PMD execution
[INFO]
[INFO] >>> pmd:3.26.0:cpd-check (cpd_check) > :cpd @ META-POM >>>
[INFO]
[INFO] --- pmd:3.26.0:cpd (cpd) @ META-POM ---
[INFO] Skipping org.apache.maven.plugins:maven-pmd-plugin:3.26.0:cpd report goal
[INFO]
[INFO] <<< pmd:3.26.0:cpd-check (cpd_check) < :cpd @ META-POM <<<
[INFO]
[INFO]
[INFO] --- pmd:3.26.0:cpd-check (cpd_check) @ META-POM ---
[INFO] Skipping CPD execution
[INFO]
[INFO] >>> spotbugs:4.9.2.0:check (default) > :spotbugs @ META-POM >>>
[INFO]
[INFO] --- spotbugs:4.9.2.0:spotbugs (spotbugs) @ META-POM ---
[INFO] Skipping com.github.spotbugs:spotbugs-maven-plugin:4.9.2.0:spotbugs report goal
[INFO]
[INFO] <<< spotbugs:4.9.2.0:check (default) < :spotbugs @ META-POM <<<
[INFO]
[INFO]
[INFO] --- spotbugs:4.9.2.0:check (default) @ META-POM ---
[INFO] Spotbugs plugin skipped
[INFO]
[INFO] --- jacoco:0.8.12:report (default) @ META-POM ---
[INFO] Skipping JaCoCo execution because property jacoco.skip is set.

---

Affects: 3.6.0

[jira-importer]

Michael Osipov commented

This does not make sense. See:

maven-checkstyle-plugin/src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleReport.java

Lines 96 to 117 in 0159511

	public boolean canGenerateReport() {
	if (skip) {
	return false;
	}
	// TODO: would be good to scan the files here
	for (File sourceDirectory : getSourceDirectories()) {
	if (sourceDirectory.exists()) {
	return true;
	}
	}
	if (includeTestSourceDirectory) {
	for (File testSourceDirectory : getTestSourceDirectories()) {
	if (testSourceDirectory.exists()) {
	return true;
	}
	}
	}
	return ((includeResources && hasResources(resources)) || (includeTestResources && hasResources(testResources)));
	}

https://github.com/apache/maven-reporting-impl/blob/649dd6bee2c8a157ddc274dd0c2d044c9a610bc5/src/main/java/org/apache/maven/reporting/AbstractMavenReport.java#L199-L215