From f73532a8e0bc10641e3ea946a1289842a655d6a8 Mon Sep 17 00:00:00 2001 From: H145608 <1404499274@qq.com> Date: Wed, 20 May 2026 12:24:34 +0800 Subject: [PATCH] [BUG] Add logging to empty catch block in DefaultRecallMessageTraceHook The catch block in doAfterResponse() was silently swallowing exceptions without any logging, making debugging impossible. Added LOG.error() to properly log exceptions when recall trace context fails to append. --- .../client/trace/hook/DefaultRecallMessageTraceHook.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/client/src/main/java/org/apache/rocketmq/client/trace/hook/DefaultRecallMessageTraceHook.java b/client/src/main/java/org/apache/rocketmq/client/trace/hook/DefaultRecallMessageTraceHook.java index c490a7b3599..66bf5751154 100644 --- a/client/src/main/java/org/apache/rocketmq/client/trace/hook/DefaultRecallMessageTraceHook.java +++ b/client/src/main/java/org/apache/rocketmq/client/trace/hook/DefaultRecallMessageTraceHook.java @@ -18,6 +18,8 @@ package org.apache.rocketmq.client.trace.hook; import org.apache.rocketmq.client.trace.TraceBean; +import org.apache.rocketmq.logging.org.slf4j.Logger; +import org.apache.rocketmq.logging.org.slf4j.LoggerFactory; import org.apache.rocketmq.client.trace.TraceContext; import org.apache.rocketmq.client.trace.TraceDispatcher; import org.apache.rocketmq.client.trace.TraceType; @@ -33,7 +35,7 @@ import java.util.ArrayList; public class DefaultRecallMessageTraceHook implements RPCHook { - + private static final Logger LOG = LoggerFactory.getLogger(DefaultRecallMessageTraceHook.class); private static final String RECALL_TRACE_ENABLE_KEY = "com.rocketmq.recall.default.trace.enable"; private boolean enableDefaultTrace = Boolean.parseBoolean(System.getProperty(RECALL_TRACE_ENABLE_KEY, "false")); private TraceDispatcher traceDispatcher; @@ -80,6 +82,7 @@ public void doAfterResponse(String remoteAddr, RemotingCommand request, Remoting traceDispatcher.append(traceContext); } catch (Exception e) { + LOG.error("Failed to append recall trace context", e); } } }