Replies: 1 comment 1 reply
-
|
To build off from this post, several PRs depend on earlier ones and won't compile on their own. Is there any preference if we open them in parallel or open them sequentially in dependency order so each PR is independently mergeable? As of now, we are working on the other PRs simultaneously and will put them up in order as the previous ones get approved. However, we are open to discussing an alternate way such that all PRs can go up in one shot. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi team, the MCS team would like to align on how we should be splitting the HuggingFace operator feature before opening the remaining PRs.
The feature is ~5,000 lines of code across ~25 files on our
huggingFacebranch. To keep each PR reviewable, we sliced it into 9 stacked PRs of ~500 lines each. The PRs are sequential: PR 2 branches off PR 1, PR 3 off PR 2, etc., so they need to land in order. PR 1 is already open as #5124.Here is the split we have in mind:
A few notes on the choices:
hugging-face.component.{ts,html,scss,spec.ts}plus the formly +app.module.tsregistrations.We'd love your guidance on two things:
1. Does the overall slicing align with what you're looking for? Anything you'd like us to regroup, merge, or split differently?
2. For PR 6 specifically: since it's noticeably larger than the others and is all frontend, would you prefer us to split it further (e.g., separate out the
.spec.ts, the.scss, or the formly/module registrations into their own PRs), or is it OK to keep the task-selector / model-browser UI together as one cohesive unit? Our concern with splitting is that the component, its styles, and its tests are tightly coupled, so fragmenting them may make individual PRs less reviewable on their own.Happy to adjust the plan before we open PRs 2-9. Thanks!
Beta Was this translation helpful? Give feedback.
All reactions