You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Backport auto-label never posts its report comment or requests release-manager review: github-script output name collision clobbers steps.label.outputs.result #7021
The Report backport decisions step in .github/workflows/backport-auto-label.yml is skipped on every run, so the report comment and release-manager review request added in #6962 never fire.
Its guard is if: ${{ steps.label.outputs.result }}. The upstream Label fix PRs step (actions/github-script, result-encoding: json) sets that output with core.setOutput("result", …), but the script has no return, so github-script auto-writes the result output to the script's undefined return value after the body runs, clobbering the explicit value. steps.label.outputs.result therefore ends up empty and the guard is always false.
Impact: a fix: PR whose modified files don't exist on a release branch (e.g. #7013) is silently skipped with no comment nudging the author to check and add the label by hand — real backports get dropped without a trace.
Expected: the report comment is posted and the branch's release manager is requested for review.
Likely fix: rename the github-script output (e.g. decisions) so it doesn't collide with github-script's reserved result, or drop result-encoding: json and return the payload instead of core.setOutput.
How to reproduce?
Open any fix: PR into main.
Open the Backport Auto Label run → the Report backport decisions step shows skipped.
What happened?
The
Report backport decisionsstep in.github/workflows/backport-auto-label.ymlis skipped on every run, so the report comment and release-manager review request added in #6962 never fire.Its guard is
if: ${{ steps.label.outputs.result }}. The upstreamLabel fix PRsstep (actions/github-script,result-encoding: json) sets that output withcore.setOutput("result", …), but the script has noreturn, so github-script auto-writes theresultoutput to the script'sundefinedreturn value after the body runs, clobbering the explicit value.steps.label.outputs.resulttherefore ends up empty and the guard is always false.Impact: a
fix:PR whose modified files don't exist on a release branch (e.g. #7013) is silently skipped with no comment nudging the author to check and add the label by hand — real backports get dropped without a trace.Expected: the report comment is posted and the branch's release manager is requested for review.
Likely fix: rename the github-script output (e.g.
decisions) so it doesn't collide with github-script's reservedresult, or dropresult-encoding: jsonandreturnthe payload instead ofcore.setOutput.How to reproduce?
fix:PR intomain.Report backport decisionsstep showsskipped.<!-- backport-auto-label-report -->comment appears. Verified 0 report comments across fix(workflow-operator): re-validate redirect hops in HF remote-URL fetches to close an SSRF bypass #7013, fix(docs): use a plain year range in NOTICE copyright #6983, fix: Add missing license headers to Docs #6958, fix(deps, frontend): update dependency ajv to v8.18.0 [security] #6908.Version/Branch
1.3.0-incubating-SNAPSHOT (main)
Commit Hash (Optional)
bfe2b53
What browsers are you seeing the problem on?
No response
Relevant log output
Run 30423275226 (PR #7013) — step "Report backport decisions": skipped