Make Cluster digester rules fully conditional on ha and tribes JARs#1021
Open
dsoumis wants to merge 1 commit into
Open
Make Cluster digester rules fully conditional on ha and tribes JARs#1021dsoumis wants to merge 1 commit into
dsoumis wants to merge 1 commit into
Conversation
dsoumis
force-pushed
the
clustering-tweaks
branch
from
f6c01d8 to
5311465
Compare
The ObjectCreate rules for the <Cluster> element were registered unconditionally in EngineRuleSet and HostRuleSet, while the child element rules in ClusterRuleSet were already guarded behind a try/catch in Catalina.addClusterRuleSet(). This caused a NoClassDefFoundError crash when catalina-tribes.jar was removed but catalina-ha.jar was present and <Cluster> was enabled in server.xml. Move the Cluster element rules into addClusterRuleSet() alongside the child element rules, and add a probe for tribes availability. Either both JARs are present and clustering works, or the <Cluster> element is ignored with an INFO log.
dsoumis
force-pushed
the
clustering-tweaks
branch
from
5311465 to
fb2192a
Compare
Contributor
|
+1 |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ObjectCreate rules for the element were registered
unconditionally in EngineRuleSet and HostRuleSet, while the child
element rules in ClusterRuleSet were already guarded behind a
try/catch in Catalina.addClusterRuleSet(). This caused a
NoClassDefFoundError crash when catalina-tribes.jar was removed
but catalina-ha.jar was present and was enabled in
server.xml.
Move the Cluster element rules into addClusterRuleSet() alongside
the child element rules, and add a probe for tribes availability.
Either both JARs are present and clustering works, or the
element is ignored with an INFO log.