Skip to content

refactor: Refactor CompileParseRules.cc for type safety, modern C++, and documentation #13196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grahamsedman wants to merge 5 commits into
base: master
Choose a base branch
from
Open

refactor: Refactor CompileParseRules.cc for type safety, modern C++, and documentation #13196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5340ed8
refactor: modernise CompileParseRules.cc for type safety and modern C++
grahamsedman May 23, 2026
7db17e9
fix: use unsigned literal in bit shift to avoid undefined behaviour
grahamsedman May 24, 2026
de9b5b3
fix: use unsigned char for byte values to avoid implementation-define…
grahamsedman May 24, 2026
06e530f
refactor: adopt Mozilla style guide and add file error handling
grahamsedman May 24, 2026
dce8c6c
fix: correct inconsistent variable names and use PascalCase functions
grahamsedman May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions include/tscore/ParseRules.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,9 @@ using CTypeResult = unsigned int;
#define is_http_field_value_BIT (((CTypeResult)1) << 31)

extern const CTypeResult parseRulesCType[];
extern const char parseRulesCTypeToUpper[];
extern const char parseRulesCTypeToLower[];
// (GS) Mod
extern const uint8_t parseRulesCTypeToUpper[];
extern const uint8_t parseRulesCTypeToLower[];

class ParseRules
{
Expand Down
Loading