feat(metadata): throwOnNotFound option#6027
Merged
Merged
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Preserve legacy POST/PUT default in ReadProvider when option unset; remove now-redundant override in MainController. Adds XSD attr, XML/YAML extractor parsing, ResourceMetadataCompatibilityTest fixture + BASE entry, XmlResourceAdapter ATTRIBUTES entry, and XmlExtractorTest/YamlExtractorTest expectations. Six new ReadProviderTest cases cover explicit true/false and default GET/POST/PUT/PUT+allowCreate paths.
Adds Feeder fixture with two Post operations (one throwOnNotFound: true, one default) backed by a state provider that returns null. Verifies the explicit option triggers a 404 (issue api-platform#6014) while default POST behavior remains unchanged.
PHPStan flagged ?self as never returning self. Provider exists to return null and trigger NotFound assertions, so narrowing to the standalone null type satisfies the analyser without altering test behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6014
Needs test