Do not fail if phpstan/phpdoc-parser is missing

[VincentLanglet]

Q	A
Branch?	4.1
Tickets	Closes #7275
License	MIT
Doc PR	api-platform/docs#...

Not fully sure about this one @soyuka but

• I assume the issue Laravel: Updating from 4.1.17 to 4.1.18 fails — Class PHPStan\PhpDocParser\Parser\TokenIterator not found #7275 is related to https://github.com/api-platform/core/pull/7204/files#diff-a74b749ab4aa559ca58d9087c4f2c9193ca78bc87ac65ab9a6a09f2d8b799581 which does not require phpstan/doc-parser since 4.18.
• Lot of PHPStan\PhpDocParser classes are used in PhpDocResourceMetadataCollectionFactory. (like

  core/src/Metadata/Resource/Factory/PhpDocResourceMetadataCollectionFactory.php

  Line 141 in d3b98b5

  $tokens = new TokenIterator($this->lexer->tokenize($rawDocNode));

  )

So since phpDocParser/lexer will be null when PhpDocParser is not installed, a null check might be enough.

[VincentLanglet]

@PicassoHouessou could you try this branch ? Does it solve your issue ?

[PicassoHouessou]

Hello @VincentLanglet. It solves my issue.

[maxhelias]

It ok for me, as "phpstan/phpdoc-parser" is also a suggested package for metadata component : https://github.com/api-platform/core/blob/4.1/src/Metadata/composer.json#L52

[maxhelias]

Also, in Laravel, can you unconfigure the service if the dependency is not present? This would be better for performance, even if there is a cache on MetadataFactory services

[soyuka]

Thanks! @maxhelias yes we just need to not register the service in the first place but if I remember we're adding this dependency inside Laravel.

[maxhelias]

@soyuka Since we’ve removed the phpdocumentor/reflection-docblock parser, phpstan/phpdoc-parser is now just a dev dependency and also appears in the "suggest" section of composer.json like the Symfony bundle.