fix(symfony): keep error serialization mapping when enable_attributes is disabled#8231
Merged
soyuka merged 1 commit intoJun 3, 2026
Merged
Conversation
… is disabled When `framework.serializer.enable_attributes: false`, Symfony registers its built-in attribute loader with `allowAnyClass: false` and no mapped classes, so it returns early for every class. As a result, api-platform's `Error` and `ValidationException` lose their `#[Groups]`, `#[SerializedName]`, and `#[Ignore]` metadata, and the problem/hydra/json:api error normalizers emit an empty payload. Register a dedicated `AttributeLoader` in `serializer.mapping.chain_loader` (and the cache warmer) that hard-codes the api-platform error classes via the `mappedClasses` argument. The loader runs regardless of the global `enable_attributes` flag, so error responses keep their structure without re-enabling attribute discovery for user classes. Fixes api-platform#8174
4 tasks
soyuka
added a commit
to soyuka/core
that referenced
this pull request
Jun 5, 2026
The pass introduced in api-platform#8231 wires AttributeLoader with the Symfony 7.x constructor signature (bool $allowAnyClass, array $mappedClasses). On Symfony 6.4 the constructor is (?Doctrine\Common\Annotations\Reader), so cache warmup crashed with a TypeError on every container build. Guard the pass via class_exists(AnnotationLoader::class) — that class only exists on the 6.4 branch (removed in 7.0). Also skip the pass when an AttributeLoader is already present in the chain (enable_attributes: true) to avoid duplicating work the framework has already wired. Fixes api-platform#8244
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
framework.serializer.enable_attributes: false, Symfony's attribute loader is configured with no mapped classes and returns early for every class, so api-platform's Error and ValidationException lose the#[Groups]/#[SerializedName]/#[Ignore]metadata that the error normalizers rely on, leaving error responses empty.Reproduction
Set
framework.serializer.enable_attributes: falseon the demo project and trigger a validation error — the response body is empty instead of the structured error payload.Test plan
Fixes #8174