refactor(scan): simplify NEON in-string probe + add ARM64 CI#34
Merged
Conversation
Replace byte_mask64 (which uses movemask16 pairwise-add chain) with vmaxvq_u8 on OR'd comparison results for detecting quote/backslash in the in-string fast path. The vmaxvq_u8 approach is ~3x faster for the probe itself, though end-to-end gains are masked by the existing memchr2 cross-chunk jump optimization. Changes: - Remove unused byte_mask16 and byte_mask64 functions (-19 lines) - Inline vmaxvq_u8 probe logic in scan_neon_impl (+12 lines) - Add ARM64 (macos-14) to CI matrix for NEON coverage - Add bench_neon128.rs for micro-benchmarking probe methods
membphis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplify NEON scanner code and add ARM64 CI coverage.
Changes
Code simplification:
byte_mask64(usesmovemask16pairwise-add chain) with inlinevmaxvq_u8probebyte_mask16andbyte_mask64functionsCI coverage:
macos-14(Apple Silicon) to test matrix