Skip to content

Commit 1c9ca4f

Browse files
authored
test: raise timeout for presigned URL fetches in integration tests (#757)
## Summary The 5s HTTP timeout on presigned-URL fetches in integration tests was too tight for the external Apify platform and occasionally tripped, causing flaky failures (e.g. [this job run](https://github.com/apify/apify-client-python/actions/runs/24832416128/job/72683975229?pr=738)). Bumped the timeout to 30s in all four affected tests (`test_dataset.py`, `test_key_value_store.py`) to absorb transient slowness while still failing fast on a truly broken endpoint.
1 parent 623c1ff commit 1c9ca4f

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

tests/integration/test_dataset.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ async def test_dataset_should_create_public_items_expiring_url_with_params(
8888
assert 'offset=0' in items_public_url
8989

9090
impit_client = impit.Client()
91-
response = impit_client.get(items_public_url, timeout=5)
91+
response = impit_client.get(items_public_url, timeout=30)
9292
assert response.status_code == 200
9393
finally:
9494
await maybe_await(dataset.delete())
@@ -110,7 +110,7 @@ async def test_dataset_should_create_public_items_non_expiring_url(
110110
assert 'signature=' in items_public_url
111111

112112
impit_client = impit.Client()
113-
response = impit_client.get(items_public_url, timeout=5)
113+
response = impit_client.get(items_public_url, timeout=30)
114114
assert response.status_code == 200
115115
finally:
116116
await maybe_await(dataset.delete())

tests/integration/test_key_value_store.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ async def test_key_value_store_should_create_expiring_keys_public_url_with_param
8282
assert 'limit=10' in keys_public_url
8383

8484
impit_client = impit.Client()
85-
response = impit_client.get(keys_public_url, timeout=5)
85+
response = impit_client.get(keys_public_url, timeout=30)
8686
assert response.status_code == 200
8787
finally:
8888
await maybe_await(store.delete())
@@ -104,7 +104,7 @@ async def test_key_value_store_should_create_public_keys_non_expiring_url(
104104
assert 'signature=' in keys_public_url
105105

106106
impit_client = impit.Client()
107-
response = impit_client.get(keys_public_url, timeout=5)
107+
response = impit_client.get(keys_public_url, timeout=30)
108108
assert response.status_code == 200
109109
finally:
110110
await maybe_await(store.delete())

0 commit comments

Comments
 (0)