refactor: derive _TERMINAL_STATUSES from TerminalActorJobStatus literal

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: vdusek

src/apify_client/_consts.py

@@ -1,10 +1,6 @@
 from __future__ import annotations
 
 from datetime import timedelta
-from typing import TYPE_CHECKING
-
-if TYPE_CHECKING:
-    from apify_client._literals import TerminalActorJobStatus
 
 DEFAULT_API_URL = 'https://api.apify.com'
 """Default base URL for the Apify API."""
@@ -36,8 +32,5 @@
 DEFAULT_WAIT_WHEN_JOB_NOT_EXIST = timedelta(seconds=3)
 """How long to wait for a job to exist before giving up."""
 
-TERMINAL_STATUSES: frozenset[TerminalActorJobStatus] = frozenset({'SUCCEEDED', 'FAILED', 'TIMED-OUT', 'ABORTED'})
-"""Set of terminal Actor job statuses that indicate the job has finished."""
-
 OVERRIDABLE_DEFAULT_HEADERS = {'Accept', 'Authorization', 'Accept-Encoding', 'User-Agent'}
 """Headers that can be overridden by users, but will trigger a warning if they do so, as it may lead to API errors."""

src/apify_client/_resource_clients/_resource_client.py

@@ -4,10 +4,11 @@
 import time
 from datetime import UTC, datetime, timedelta
 from functools import cached_property
-from typing import TYPE_CHECKING, Any
+from typing import TYPE_CHECKING, Any, get_args
 
-from apify_client._consts import DEFAULT_WAIT_FOR_FINISH, DEFAULT_WAIT_WHEN_JOB_NOT_EXIST, TERMINAL_STATUSES
+from apify_client._consts import DEFAULT_WAIT_FOR_FINISH, DEFAULT_WAIT_WHEN_JOB_NOT_EXIST
 from apify_client._docs import docs_group
+from apify_client._literals import TerminalActorJobStatus
 from apify_client._logging import WithLogDetailsClient
 from apify_client._models import ActorJobResponse
 from apify_client._utils import (
@@ -24,6 +25,8 @@
     from apify_client._http_clients import HttpClient, HttpClientAsync
     from apify_client._literals import Timeout
 
+_TERMINAL_STATUSES: frozenset[TerminalActorJobStatus] = frozenset(get_args(TerminalActorJobStatus))
+
 
 class ResourceClientBase(metaclass=WithLogDetailsClient):
     """Base class with shared implementation for sync and async resource clients.
@@ -333,7 +336,7 @@ def _wait_for_finish(
                 # Reset the not-found streak so a later transient 404 gets its own grace window.
                 not_found_deadline = None
 
-                is_terminal = actor_job_response.data.status in TERMINAL_STATUSES
+                is_terminal = actor_job_response.data.status in _TERMINAL_STATUSES
                 is_timed_out = deadline is not None and datetime.now(UTC) >= deadline
 
                 if is_terminal or is_timed_out:
@@ -526,7 +529,7 @@ async def _wait_for_finish(
                 # Reset the not-found streak so a later transient 404 gets its own grace window.
                 not_found_deadline = None
 
-                is_terminal = actor_job_response.data.status in TERMINAL_STATUSES
+                is_terminal = actor_job_response.data.status in _TERMINAL_STATUSES
                 is_timed_out = deadline is not None and datetime.now(UTC) >= deadline
 
                 if is_terminal or is_timed_out: