From bcb3957347fb9f7280fe27016452c60e0a52e3a2 Mon Sep 17 00:00:00 2001 From: Vlada Dusek Date: Wed, 13 May 2026 18:58:40 +0200 Subject: [PATCH 1/7] ci: add package verification check Adds an end-to-end check that the built sdist and wheel install cleanly and contain the expected sources via the shared apify/workflows/python-package-check action. Runs on every PR and inside the release flow between prepare-pypi-distribution and the PyPI publish step, guarding against silent build regressions. --- .github/workflows/_check_package.yaml | 29 ++++++++++++++++++++ .github/workflows/manual_release_beta.yaml | 5 ++++ .github/workflows/manual_release_stable.yaml | 5 ++++ .github/workflows/on_pull_request.yaml | 4 +++ 4 files changed, 43 insertions(+) create mode 100644 .github/workflows/_check_package.yaml diff --git a/.github/workflows/_check_package.yaml b/.github/workflows/_check_package.yaml new file mode 100644 index 00000000..a8b18a55 --- /dev/null +++ b/.github/workflows/_check_package.yaml @@ -0,0 +1,29 @@ +name: Package check + +on: + workflow_dispatch: + workflow_call: + +permissions: + contents: read + +jobs: + package_check: + name: Package check + runs-on: ubuntu-latest + steps: + - name: Checkout repository + uses: actions/checkout@v6 + + - name: Set up uv package manager + uses: astral-sh/setup-uv@v8.1.0 + with: + python-version: "3.14" + + - name: Build sdist and wheel + run: uv run poe build + + - name: Verify built package + uses: apify/workflows/python-package-check@main + with: + package_name: apify_client diff --git a/.github/workflows/manual_release_beta.yaml b/.github/workflows/manual_release_beta.yaml index 5be9517e..dc0d4069 100644 --- a/.github/workflows/manual_release_beta.yaml +++ b/.github/workflows/manual_release_beta.yaml @@ -60,6 +60,11 @@ jobs: version_number: ${{ needs.release_prepare.outputs.version_number }} ref: ${{ needs.changelog_update.outputs.changelog_commitish }} + - name: Verify built package + uses: apify/workflows/python-package-check@main + with: + package_name: apify_client + # Publish the package to PyPI using PyPA official GitHub action with OIDC authentication. - name: Publish package to PyPI uses: pypa/gh-action-pypi-publish@release/v1 diff --git a/.github/workflows/manual_release_stable.yaml b/.github/workflows/manual_release_stable.yaml index 9460e63e..0c2cf134 100644 --- a/.github/workflows/manual_release_stable.yaml +++ b/.github/workflows/manual_release_stable.yaml @@ -98,6 +98,11 @@ jobs: version_number: ${{ needs.release_prepare.outputs.version_number }} ref: ${{ needs.changelog_update.outputs.changelog_commitish }} + - name: Verify built package + uses: apify/workflows/python-package-check@main + with: + package_name: apify_client + # Publish the package to PyPI using PyPA official GitHub action with OIDC authentication. - name: Publish package to PyPI uses: pypa/gh-action-pypi-publish@release/v1 diff --git a/.github/workflows/on_pull_request.yaml b/.github/workflows/on_pull_request.yaml index 39e5d6a8..a66bdee7 100644 --- a/.github/workflows/on_pull_request.yaml +++ b/.github/workflows/on_pull_request.yaml @@ -29,6 +29,10 @@ jobs: name: Docstrings checks uses: ./.github/workflows/_check_docstrings.yaml + package_check: + name: Package check + uses: ./.github/workflows/_check_package.yaml + tests: name: Tests uses: ./.github/workflows/_tests.yaml From 315b539f1f714803dc2ae8b79146b48fd9ea965c Mon Sep 17 00:00:00 2001 From: Vlada Dusek Date: Thu, 14 May 2026 11:04:34 +0200 Subject: [PATCH 2/7] ci: pass new required inputs to python-package-check action Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/_check_package.yaml | 3 +++ .github/workflows/manual_release_beta.yaml | 3 +++ .github/workflows/manual_release_stable.yaml | 3 +++ 3 files changed, 9 insertions(+) diff --git a/.github/workflows/_check_package.yaml b/.github/workflows/_check_package.yaml index a8b18a55..0e282934 100644 --- a/.github/workflows/_check_package.yaml +++ b/.github/workflows/_check_package.yaml @@ -27,3 +27,6 @@ jobs: uses: apify/workflows/python-package-check@main with: package_name: apify_client + src_package_dir: src/apify_client + dist_dir: dist + python_version: "3.14" diff --git a/.github/workflows/manual_release_beta.yaml b/.github/workflows/manual_release_beta.yaml index dc0d4069..79acfe70 100644 --- a/.github/workflows/manual_release_beta.yaml +++ b/.github/workflows/manual_release_beta.yaml @@ -64,6 +64,9 @@ jobs: uses: apify/workflows/python-package-check@main with: package_name: apify_client + src_package_dir: src/apify_client + dist_dir: dist + python_version: "3.14" # Publish the package to PyPI using PyPA official GitHub action with OIDC authentication. - name: Publish package to PyPI diff --git a/.github/workflows/manual_release_stable.yaml b/.github/workflows/manual_release_stable.yaml index 0c2cf134..28840bf1 100644 --- a/.github/workflows/manual_release_stable.yaml +++ b/.github/workflows/manual_release_stable.yaml @@ -102,6 +102,9 @@ jobs: uses: apify/workflows/python-package-check@main with: package_name: apify_client + src_package_dir: src/apify_client + dist_dir: dist + python_version: "3.14" # Publish the package to PyPI using PyPA official GitHub action with OIDC authentication. - name: Publish package to PyPI From 5a921f76ed352d3178e524f42cf154ab289627ed Mon Sep 17 00:00:00 2001 From: Vlada Dusek Date: Thu, 14 May 2026 11:15:39 +0200 Subject: [PATCH 3/7] ci: use shared python_package_check workflow from apify/workflows Replaces the local _check_package.yaml with a direct call to the shared reusable workflow. Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/_check_package.yaml | 32 -------------------------- .github/workflows/on_pull_request.yaml | 5 +++- 2 files changed, 4 insertions(+), 33 deletions(-) delete mode 100644 .github/workflows/_check_package.yaml diff --git a/.github/workflows/_check_package.yaml b/.github/workflows/_check_package.yaml deleted file mode 100644 index 0e282934..00000000 --- a/.github/workflows/_check_package.yaml +++ /dev/null @@ -1,32 +0,0 @@ -name: Package check - -on: - workflow_dispatch: - workflow_call: - -permissions: - contents: read - -jobs: - package_check: - name: Package check - runs-on: ubuntu-latest - steps: - - name: Checkout repository - uses: actions/checkout@v6 - - - name: Set up uv package manager - uses: astral-sh/setup-uv@v8.1.0 - with: - python-version: "3.14" - - - name: Build sdist and wheel - run: uv run poe build - - - name: Verify built package - uses: apify/workflows/python-package-check@main - with: - package_name: apify_client - src_package_dir: src/apify_client - dist_dir: dist - python_version: "3.14" diff --git a/.github/workflows/on_pull_request.yaml b/.github/workflows/on_pull_request.yaml index a66bdee7..6feac795 100644 --- a/.github/workflows/on_pull_request.yaml +++ b/.github/workflows/on_pull_request.yaml @@ -31,7 +31,10 @@ jobs: package_check: name: Package check - uses: ./.github/workflows/_check_package.yaml + uses: apify/workflows/.github/workflows/python_package_check.yaml@main + with: + package_name: apify_client + src_package_dir: src/apify_client tests: name: Tests From d7e3e3a93db1a6692ee01cdce2e9b81175537dd0 Mon Sep 17 00:00:00 2001 From: Vlada Dusek Date: Thu, 14 May 2026 11:19:26 +0200 Subject: [PATCH 4/7] ci: pass dist_dir and python_version to shared package check workflow Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/on_pull_request.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/on_pull_request.yaml b/.github/workflows/on_pull_request.yaml index 6feac795..795e823f 100644 --- a/.github/workflows/on_pull_request.yaml +++ b/.github/workflows/on_pull_request.yaml @@ -35,6 +35,8 @@ jobs: with: package_name: apify_client src_package_dir: src/apify_client + dist_dir: dist + python_version: "3.14" tests: name: Tests From f056ffa1795dc0fc51b5d3c773b18abd3d742a6a Mon Sep 17 00:00:00 2001 From: Vlada Dusek Date: Thu, 14 May 2026 11:22:21 +0200 Subject: [PATCH 5/7] ci: add a basic smoke check to the python package verification Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/manual_release_beta.yaml | 4 ++++ .github/workflows/manual_release_stable.yaml | 4 ++++ .github/workflows/on_pull_request.yaml | 4 ++++ 3 files changed, 12 insertions(+) diff --git a/.github/workflows/manual_release_beta.yaml b/.github/workflows/manual_release_beta.yaml index 79acfe70..c513936e 100644 --- a/.github/workflows/manual_release_beta.yaml +++ b/.github/workflows/manual_release_beta.yaml @@ -67,6 +67,10 @@ jobs: src_package_dir: src/apify_client dist_dir: dist python_version: "3.14" + smoke_code: | + from apify_client import ApifyClient, ApifyClientAsync + ApifyClient(token='x') + ApifyClientAsync(token='x') # Publish the package to PyPI using PyPA official GitHub action with OIDC authentication. - name: Publish package to PyPI diff --git a/.github/workflows/manual_release_stable.yaml b/.github/workflows/manual_release_stable.yaml index 28840bf1..2dac695d 100644 --- a/.github/workflows/manual_release_stable.yaml +++ b/.github/workflows/manual_release_stable.yaml @@ -105,6 +105,10 @@ jobs: src_package_dir: src/apify_client dist_dir: dist python_version: "3.14" + smoke_code: | + from apify_client import ApifyClient, ApifyClientAsync + ApifyClient(token='x') + ApifyClientAsync(token='x') # Publish the package to PyPI using PyPA official GitHub action with OIDC authentication. - name: Publish package to PyPI diff --git a/.github/workflows/on_pull_request.yaml b/.github/workflows/on_pull_request.yaml index 795e823f..b7465dba 100644 --- a/.github/workflows/on_pull_request.yaml +++ b/.github/workflows/on_pull_request.yaml @@ -37,6 +37,10 @@ jobs: src_package_dir: src/apify_client dist_dir: dist python_version: "3.14" + smoke_code: | + from apify_client import ApifyClient, ApifyClientAsync + ApifyClient(token='x') + ApifyClientAsync(token='x') tests: name: Tests From cf37b83f3b7131d89a5e36e2f712929de0ab312f Mon Sep 17 00:00:00 2001 From: Vlada Dusek Date: Thu, 14 May 2026 11:30:18 +0200 Subject: [PATCH 6/7] ci: inline package-check recipe, drop shared reusable workflow indirection Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/on_pull_request.yaml | 34 ++++++++++++++++++-------- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/.github/workflows/on_pull_request.yaml b/.github/workflows/on_pull_request.yaml index b7465dba..95adcd69 100644 --- a/.github/workflows/on_pull_request.yaml +++ b/.github/workflows/on_pull_request.yaml @@ -31,16 +31,30 @@ jobs: package_check: name: Package check - uses: apify/workflows/.github/workflows/python_package_check.yaml@main - with: - package_name: apify_client - src_package_dir: src/apify_client - dist_dir: dist - python_version: "3.14" - smoke_code: | - from apify_client import ApifyClient, ApifyClientAsync - ApifyClient(token='x') - ApifyClientAsync(token='x') + runs-on: ubuntu-latest + steps: + - name: Checkout repository + uses: actions/checkout@v6 + + - name: Set up uv package manager + uses: astral-sh/setup-uv@v8.1.0 + with: + python-version: "3.14" + + - name: Build sdist and wheel + run: uv run poe build + + - name: Verify built package + uses: apify/workflows/python-package-check@main + with: + package_name: apify_client + src_package_dir: src/apify_client + dist_dir: dist + python_version: "3.14" + smoke_code: | + from apify_client import ApifyClient, ApifyClientAsync + ApifyClient(token='x') + ApifyClientAsync(token='x') tests: name: Tests From bbd5ca572aa022974e8dae1eae803ef8c1ccb5f9 Mon Sep 17 00:00:00 2001 From: Vlada Dusek Date: Thu, 14 May 2026 11:38:59 +0200 Subject: [PATCH 7/7] ci: extract package_check job into _check_package.yaml Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/_check_package.yaml | 39 ++++++++++++++++++++++++++ .github/workflows/on_pull_request.yaml | 25 +---------------- 2 files changed, 40 insertions(+), 24 deletions(-) create mode 100644 .github/workflows/_check_package.yaml diff --git a/.github/workflows/_check_package.yaml b/.github/workflows/_check_package.yaml new file mode 100644 index 00000000..f99ddf73 --- /dev/null +++ b/.github/workflows/_check_package.yaml @@ -0,0 +1,39 @@ +name: Package check + +on: + # Runs when manually triggered from the GitHub UI. + workflow_dispatch: + + # Runs when invoked by another workflow. + workflow_call: + +permissions: + contents: read + +jobs: + package_check: + name: Package check + runs-on: ubuntu-latest + steps: + - name: Checkout repository + uses: actions/checkout@v6 + + - name: Set up uv package manager + uses: astral-sh/setup-uv@v8.1.0 + with: + python-version: "3.14" + + - name: Build sdist and wheel + run: uv run poe build + + - name: Verify built package + uses: apify/workflows/python-package-check@main + with: + package_name: apify_client + src_package_dir: src/apify_client + dist_dir: dist + python_version: "3.14" + smoke_code: | + from apify_client import ApifyClient, ApifyClientAsync + ApifyClient(token='x') + ApifyClientAsync(token='x') diff --git a/.github/workflows/on_pull_request.yaml b/.github/workflows/on_pull_request.yaml index 95adcd69..a66bdee7 100644 --- a/.github/workflows/on_pull_request.yaml +++ b/.github/workflows/on_pull_request.yaml @@ -31,30 +31,7 @@ jobs: package_check: name: Package check - runs-on: ubuntu-latest - steps: - - name: Checkout repository - uses: actions/checkout@v6 - - - name: Set up uv package manager - uses: astral-sh/setup-uv@v8.1.0 - with: - python-version: "3.14" - - - name: Build sdist and wheel - run: uv run poe build - - - name: Verify built package - uses: apify/workflows/python-package-check@main - with: - package_name: apify_client - src_package_dir: src/apify_client - dist_dir: dist - python_version: "3.14" - smoke_code: | - from apify_client import ApifyClient, ApifyClientAsync - ApifyClient(token='x') - ApifyClientAsync(token='x') + uses: ./.github/workflows/_check_package.yaml tests: name: Tests