From 6c5775ae314a635245450c8c335855d1633fcd37 Mon Sep 17 00:00:00 2001
From: nichenqin <nichenqin@hotmail.com>
Date: Thu, 7 May 2026 14:31:18 +0800
Subject: [PATCH] fix: keep pr comments best effort

---
 README.md             |  6 ++++--
 scripts/run-deploy.sh | 25 +++++++++++++++++++------
 2 files changed, 23 insertions(+), 8 deletions(-)

diff --git a/README.md b/README.md
index 82eda6d..a50a876 100644
--- a/README.md
+++ b/README.md
@@ -208,7 +208,8 @@ When `pr-comment: true`, the action posts or updates one stable pull request com
 preview URL, console URL, deployment id, or cleanup status that is available for the selected mode.
 The workflow must pass `github-token: ${{ github.token }}` and grant `pull-requests: write` or
 `issues: write`. This is entrypoint feedback only; product-grade GitHub App comments/checks remain
-control-plane features.
+control-plane features. Comment publishing is best-effort: GitHub API permission failures are
+reported as warnings and do not fail an otherwise successful deployment or cleanup.
 
 The control-plane connection policy can live in `appaloft.yml`:
 
@@ -284,7 +285,8 @@ source-link state, or the Appaloft server, not from committed config.
   preview scope inputs. Deployment target ids are intentionally ignored/rejected because cleanup
   resolves from server-owned source-link state.
 - `pr-comment` requires explicit workflow permission and token wiring. The action updates the same
-  marker comment for the PR instead of creating a new comment on each run.
+  marker comment for the PR instead of creating a new comment on each run. Comment API failures are
+  warnings so they do not mask a successful deployment.
 
 ## Product-Grade Previews
 
diff --git a/scripts/run-deploy.sh b/scripts/run-deploy.sh
index ff5f7dc..4a1dba4 100755
--- a/scripts/run-deploy.sh
+++ b/scripts/run-deploy.sh
@@ -311,6 +311,10 @@ build_pr_comment_body() {
   ' "$1" "$wrapper_command" "$preview_id" "${control_plane_url:-}" "${preview_url:-}" "${deployment_id:-}" "${cleanup_status:-}"
 }
 
+warn_pr_comment_skipped() {
+  echo "::warning::Appaloft PR comment was not published: $1" >&2
+}
+
 maybe_publish_pr_comment() {
   if ! truthy "$pr_comment"; then
     return 0
@@ -336,10 +340,13 @@ maybe_publish_pr_comment() {
   fi
 
   comment_payload="$(build_pr_comment_body "$comment_marker")"
-  comments_response="$(curl -fsS \
+  if ! comments_response="$(curl -fsS \
     -H "Authorization: Bearer ${github_token}" \
     -H "Accept: application/vnd.github+json" \
-    "$(github_api_url "${comments_path}?per_page=100")")"
+    "$(github_api_url "${comments_path}?per_page=100")")"; then
+    warn_pr_comment_skipped "could not list pull request comments"
+    return 0
+  fi
   comment_id="$(COMMENT_MARKER="$comment_marker" node -e '
     const fs = require("fs");
     const comments = JSON.parse(fs.readFileSync(0, "utf8"));
@@ -354,19 +361,25 @@ EOF
 )"
 
   if [ -n "$comment_id" ]; then
-    curl -fsS -X PATCH \
+    if ! curl -fsS -X PATCH \
       -H "Authorization: Bearer ${github_token}" \
       -H "Accept: application/vnd.github+json" \
       -H "Content-Type: application/json" \
       --data "$comment_payload" \
-      "$(github_api_url "/repos/${GITHUB_REPOSITORY}/issues/comments/${comment_id}")" >/dev/null
+      "$(github_api_url "/repos/${GITHUB_REPOSITORY}/issues/comments/${comment_id}")" >/dev/null; then
+      warn_pr_comment_skipped "could not update pull request comment"
+      return 0
+    fi
   else
-    curl -fsS -X POST \
+    if ! curl -fsS -X POST \
       -H "Authorization: Bearer ${github_token}" \
       -H "Accept: application/vnd.github+json" \
       -H "Content-Type: application/json" \
       --data "$comment_payload" \
-      "$(github_api_url "$comments_path")" >/dev/null
+      "$(github_api_url "$comments_path")" >/dev/null; then
+      warn_pr_comment_skipped "could not create pull request comment"
+      return 0
+    fi
   fi
 }