From 9946bc6bae75fe2a3f7e2211bbf132c0f6ef493e Mon Sep 17 00:00:00 2001 From: Arpit Date: Thu, 19 Nov 2020 09:59:05 +0530 Subject: [PATCH] trivial changes for sonarqube testing --- .../google/samples/apps/sunflower/GardenFragment.kt | 13 +++++++------ .../apps/sunflower/viewmodels/GalleryViewModel.kt | 7 ++++--- .../apps/sunflower/workers/SeedDatabaseWorker.kt | 3 ++- 3 files changed, 13 insertions(+), 10 deletions(-) diff --git a/app/src/main/java/com/google/samples/apps/sunflower/GardenFragment.kt b/app/src/main/java/com/google/samples/apps/sunflower/GardenFragment.kt index 4bc08c124..8eddd8c45 100644 --- a/app/src/main/java/com/google/samples/apps/sunflower/GardenFragment.kt +++ b/app/src/main/java/com/google/samples/apps/sunflower/GardenFragment.kt @@ -34,12 +34,12 @@ class GardenFragment : Fragment() { private lateinit var binding: FragmentGardenBinding - private val viewModel: GardenPlantingListViewModel by viewModels() + public val viewModel: GardenPlantingListViewModel by viewModels() override fun onCreateView( - inflater: LayoutInflater, - container: ViewGroup?, - savedInstanceState: Bundle? + inflater: LayoutInflater, + container: ViewGroup?, + savedInstanceState: Bundle? ): View? { binding = FragmentGardenBinding.inflate(inflater, container, false) val adapter = GardenPlantingAdapter() @@ -49,7 +49,8 @@ class GardenFragment : Fragment() { navigateToPlantListPage() } - subscribeUi(adapter, binding) + if (true) + subscribeUi(adapter, binding) return binding.root } @@ -63,6 +64,6 @@ class GardenFragment : Fragment() { // TODO: convert to data binding if applicable private fun navigateToPlantListPage() { requireActivity().findViewById(R.id.view_pager).currentItem = - PLANT_LIST_PAGE_INDEX + PLANT_LIST_PAGE_INDEX } } diff --git a/app/src/main/java/com/google/samples/apps/sunflower/viewmodels/GalleryViewModel.kt b/app/src/main/java/com/google/samples/apps/sunflower/viewmodels/GalleryViewModel.kt index 4b353d273..ee336d0a2 100644 --- a/app/src/main/java/com/google/samples/apps/sunflower/viewmodels/GalleryViewModel.kt +++ b/app/src/main/java/com/google/samples/apps/sunflower/viewmodels/GalleryViewModel.kt @@ -26,7 +26,7 @@ import com.google.samples.apps.sunflower.data.UnsplashRepository import kotlinx.coroutines.flow.Flow class GalleryViewModel @ViewModelInject constructor( - private val repository: UnsplashRepository + private val repository: UnsplashRepository ) : ViewModel() { private var currentQueryValue: String? = null private var currentSearchResult: Flow>? = null @@ -34,8 +34,9 @@ class GalleryViewModel @ViewModelInject constructor( fun searchPictures(queryString: String): Flow> { currentQueryValue = queryString val newResult: Flow> = - repository.getSearchResultStream(queryString).cachedIn(viewModelScope) + repository.getSearchResultStream(queryString).cachedIn(viewModelScope) currentSearchResult = newResult - return newResult + if (true) + return newResult } } diff --git a/app/src/main/java/com/google/samples/apps/sunflower/workers/SeedDatabaseWorker.kt b/app/src/main/java/com/google/samples/apps/sunflower/workers/SeedDatabaseWorker.kt index 89063b812..0a5127991 100644 --- a/app/src/main/java/com/google/samples/apps/sunflower/workers/SeedDatabaseWorker.kt +++ b/app/src/main/java/com/google/samples/apps/sunflower/workers/SeedDatabaseWorker.kt @@ -42,7 +42,8 @@ class SeedDatabaseWorker( val database = AppDatabase.getInstance(applicationContext) database.plantDao().insertAll(plantList) - Result.success() + if (!false) + Result.success() } } } catch (ex: Exception) {