Merge pull request #129 from askui/fix/android-screencap

onur-askui · web-flow · commit 2d223ee89650 · 2025-08-27T10:47:10.000Z
Support devices with empty display name
diff --git a/src/askui/tools/android/ppadb_agent_os.py b/src/askui/tools/android/ppadb_agent_os.py
@@ -50,7 +50,7 @@ def get_connected_displays(self) -> list[AndroidDisplay]:
         for line in output.splitlines():
             if line.startswith("Display"):
                 match = re.match(
-                    r"Display (\d+) .* displayName=\"([^\"]+)\"",
+                    r"Display (\d+) .* displayName=\"([^\"]*?)\"",
                     line,
                 )
                 if match:

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ def get_connected_displays(self) -> list[AndroidDisplay]:`
`50`	`50`	`for line in output.splitlines():`
`51`	`51`	`if line.startswith("Display"):`
`52`	`52`	`match = re.match(`
`53`		`- r"Display (\d+) .* displayName=\"([^\"]+)\"",`
	`53`	`+ r"Display (\d+) .* displayName=\"([^\"]*?)\"",`
`54`	`54`	`line,`
`55`	`55`	`)`
`56`	`56`	`if match:`