fix QA findings

Author: mlikasam-askui

src/askui/android_agent.py

@@ -421,8 +421,8 @@ def key_tap(
             from askui import AndroidVisionAgent
 
             with AndroidVisionAgent() as agent:
-                agent.key_tap("KEYCODE_HOME")  # Taps the home key
-                agent.key_tap("KEYCODE_BACK")  # Taps the back key
+                agent.key_tap("home")  # Taps the home key
+                agent.key_tap("back")  # Taps the back key
             ```
         """
         self.os.key_tap(key)
@@ -446,8 +446,8 @@ def key_combination(
             from askui import AndroidVisionAgent
 
             with AndroidVisionAgent() as agent:
-                agent.key_combination(["KEYCODE_HOME", "KEYCODE_BACK"])  # Taps the home key and then the back key
-                agent.key_combination(["KEYCODE_HOME", "KEYCODE_BACK"], duration_in_ms=200)  # Taps the home key and then the back key with a 200ms delay
+                agent.key_combination(["home", "back"])  # Taps the home key and then the back key
+                agent.key_combination(["home", "back"], duration_in_ms=200)  # Taps the home key and then the back key for 200ms.
             ```
         """
         self.os.key_combination(keys, duration_in_ms)
@@ -536,27 +536,27 @@ def swipe(
         self.os.swipe(x1, y1, x2, y2, duration_in_ms)
 
     @telemetry.record_call(
-        exclude={"device_name"},
+        exclude={"device_serial_number"},
     )
     @validate_call
-    def set_device_by_name(
+    def set_device_by_serial_number(
         self,
-        device_name: str,
+        device_serial_number: str,
     ) -> None:
         """
         Sets the active device for screen interactions by name.
 
         Args:
-            device_name (str): The name of the device to set as active.
+            device_serial_number (str): The serial number of the device to set as active.
 
         Example:
             ```python
             from askui import AndroidVisionAgent
 
             with AndroidVisionAgent() as agent:
-                agent.set_device_by_name("Pixel 6")  # Sets the active device to the Pixel 6
+                agent.set_device_by_serial_number("Pixel 6")  # Sets the active device to the Pixel 6
         """
-        self.os.set_device_by_name(device_name)
+        self.os.set_device_by_serial_number(device_serial_number)
 
     @telemetry.record_call(exclude={"goal", "on_message"})
     @validate_call

src/askui/tools/android/agent_os.py

@@ -375,9 +375,9 @@ def set_device_by_index(self, device_index: int = 0) -> None:
         raise NotImplementedError
 
     @abstractmethod
-    def set_device_by_name(self, device_name: str) -> None:
+    def set_device_by_serial_number(self, device_serial_number: str) -> None:
         """
-        Sets the active device for screen interactions by name.
+        Sets the active device for screen interactions by serial number.
         """
         raise NotImplementedError
 

src/askui/tools/android/agent_os_handler.py

@@ -139,9 +139,9 @@ def set_device_by_index(self, device_index: int = 0) -> None:
             "AndroidAgentOS", f"Set device by index: {device_index}"
         )
 
-    def set_device_by_name(self, device_name: str) -> None:
-        self._os_agent.set_device_by_name(device_name)
+    def set_device_by_serial_number(self, device_serial_number: str) -> None:
+        self._os_agent.set_device_by_serial_number(device_serial_number)
         self._real_screen_resolution = None
         self._reporter.add_message(
-            "AndroidAgentOS", f"Set device by name: {device_name}"
+            "AndroidAgentOS", f"Set device by serial number: {device_serial_number}"
         )

src/askui/tools/android/ppadb_agent_os.py

@@ -1,5 +1,6 @@
 import io
 import re
+import shlex
 import string
 from typing import List, Optional, get_args
 
@@ -110,14 +111,14 @@ def set_device_by_index(self, device_index: int = 0) -> None:
         self._device = devices[device_index]
         self.set_display_by_index(0)
 
-    def set_device_by_name(self, device_name: str) -> None:
+    def set_device_by_serial_number(self, device_serial_number: str) -> None:
         devices = self._get_connected_devices()
         for device in devices:
-            if device.serial == device_name:
+            if device.serial == device_serial_number:
                 self._device = device
                 self.set_display_by_index(0)
                 return
-        msg = f"Device name {device_name} not found"
+        msg = f"Device name {device_serial_number} not found"
         raise RuntimeError(msg)
 
     def screenshot(self) -> Image.Image:
@@ -186,7 +187,12 @@ def type(self, text: str) -> None:
             raise RuntimeError(error_msg_nonprintable)
         assert self._selected_display is not None
         display_index: int = self._selected_display.display_index
-        self.shell(f"input -d {display_index} text {text}")
+
+        escaped_text = shlex.quote(text)
+
+        shell_safe_text = escaped_text.replace(" ", "%s")
+
+        self.shell(f"input -d {display_index} text {shell_safe_text}")
 
     def key_tap(self, key: ANDROID_KEY) -> None:
         if key not in get_args(ANDROID_KEY):