Merge pull request #233 from askui/feat/mouse_move_speed

feat: make `duration` a parameter of `mouse_movement` to enable fast mouse movement

Author: philipph-askui

src/askui/tools/agent_os.py

@@ -261,13 +261,14 @@ def screenshot(self, report: bool = True) -> Image.Image:
         raise NotImplementedError
 
     @abstractmethod
-    def mouse_move(self, x: int, y: int) -> None:
+    def mouse_move(self, x: int, y: int, duration: int = 500) -> None:
         """
         Moves the mouse cursor to specified screen coordinates.
 
         Args:
             x (int): The horizontal coordinate (in pixels) to move to.
             y (int): The vertical coordinate (in pixels) to move to.
+            duration (int): The duration (in ms) the movement should take.
         """
         raise NotImplementedError
 

src/askui/tools/askui/askui_controller.py

@@ -367,25 +367,26 @@ def screenshot(self, report: bool = True) -> Image.Image:
 
     @telemetry.record_call()
     @override
-    def mouse_move(self, x: int, y: int) -> None:
+    def mouse_move(self, x: int, y: int, duration: int = 500) -> None:
         """
         Moves the mouse cursor to specified screen coordinates.
 
         Args:
             x (int): The horizontal coordinate (in pixels) to move to.
             y (int): The vertical coordinate (in pixels) to move to.
+            duration (int): The duration (in ms) the movement should take.
         """
         self._reporter.add_message(
             "AgentOS",
-            f"mouse_move({x}, {y})",
+            f"mouse_move({x}, {y}, duration={duration})",
             AnnotatedImage(lambda: self.screenshot(report=False), point_list=[(x, y)]),
         )
         self._run_recorder_action(
             acion_class_id=controller_v1_pbs.ActionClassID_MouseMove,
             action_parameters=controller_v1_pbs.ActionParameters(
                 mouseMove=controller_v1_pbs.ActionParameters_MouseMove(
                     position=controller_v1_pbs.Coordinate2(x=x, y=y),
-                    milliseconds=500,
+                    milliseconds=duration,
                 )
             ),
         )

src/askui/tools/computer_agent_os_facade.py

@@ -57,9 +57,9 @@ def screenshot(self, report: bool = True) -> Image.Image:
         )
         return scale_image_to_fit(screenshot, self._target_resolution)
 
-    def mouse_move(self, x: int, y: int) -> None:
+    def mouse_move(self, x: int, y: int, duration: int = 500) -> None:
         scaled_x, scaled_y = self._scale_coordinates_back(x, y)
-        self._agent_os.mouse_move(scaled_x, scaled_y)
+        self._agent_os.mouse_move(scaled_x, scaled_y, duration)
 
     def get_mouse_position(self) -> Coordinate:
         mouse_position = self._agent_os.get_mouse_position()

src/askui/tools/playwright/agent_os.py

@@ -179,13 +179,14 @@ def screenshot(self, report: bool = True) -> Image.Image:
         return Image.open(io.BytesIO(screenshot_bytes))
 
     @override
-    def mouse_move(self, x: int, y: int) -> None:
+    def mouse_move(self, x: int, y: int, _duration: int = 500) -> None:
         """
         Moves the mouse cursor to specified coordinates on the page.
 
         Args:
             x (int): The horizontal coordinate (in pixels) to move to.
             y (int): The vertical coordinate (in pixels) to move to.
+            _duration (int): Unused parameter as it is not applicable here.
         """
         if not self._page:
             error_msg = "No active page. Call connect() first."