Skip to content

Commit 3f68c3c

Browse files
refactor: rename cache size variable and reorganize test comments
1 parent 307000b commit 3f68c3c

3 files changed

Lines changed: 11 additions & 12 deletions

File tree

File renamed without changes.

src/auth0_server_python/auth_server/server_client.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def __init__(
145145
self._metadata_cache = {} # {domain: {"data": {...}, "expires_at": timestamp}}
146146
self._jwks_cache = {} # {domain: {"data": {...}, "expires_at": timestamp}}
147147
self._cache_ttl = 3600 # 1 hour TTL
148-
self._cache_max_size = 100 # Max 100 domains to prevent memory bloat
148+
self._cache_max_entries = 100 # Max 100 domains to prevent memory bloat
149149

150150
# ==========================================
151151
# Interactive Login Flow
@@ -1090,7 +1090,7 @@ async def _get_oidc_metadata_cached(self, domain: str) -> dict:
10901090
metadata = await self._fetch_oidc_metadata(domain)
10911091

10921092
# Enforce cache size limit (FIFO eviction)
1093-
if len(self._metadata_cache) >= self._cache_max_size:
1093+
if len(self._metadata_cache) >= self._cache_max_entries:
10941094
oldest_key = next(iter(self._metadata_cache))
10951095
del self._metadata_cache[oldest_key]
10961096

@@ -1160,7 +1160,7 @@ async def _get_jwks_cached(self, domain: str, metadata: dict = None) -> dict:
11601160
jwks = await self._fetch_jwks(jwks_uri)
11611161

11621162
# Enforce cache size limit (FIFO eviction)
1163-
if len(self._jwks_cache) >= self._cache_max_size:
1163+
if len(self._jwks_cache) >= self._cache_max_entries:
11641164
oldest_key = next(iter(self._jwks_cache))
11651165
del self._jwks_cache[oldest_key]
11661166

src/auth0_server_python/tests/test_server_client.py

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1978,7 +1978,7 @@ async def test_complete_connect_account_no_transactions(mocker):
19781978

19791979

19801980
# =============================================================================
1981-
# Requirement 1: Multiple Issuer Configuration Methods Tests
1981+
# MCD Tests : Multiple Issuer Configuration Methods Tests
19821982
# =============================================================================
19831983

19841984
@pytest.mark.asyncio
@@ -2049,7 +2049,7 @@ async def test_empty_domain_string():
20492049

20502050

20512051
# =============================================================================
2052-
# Requirement 2: Domain Resolver Context Tests
2052+
# MCD Tests : Domain Resolver Context Tests
20532053
# =============================================================================
20542054

20552055
@pytest.mark.asyncio
@@ -2179,8 +2179,7 @@ async def domain_resolver(context):
21792179
try:
21802180
await client.start_interactive_login(store_options=None)
21812181
except Exception: # noqa: S110
2182-
pass # Intentionally ignore - testing context only
2183-
2182+
pass # We only care about context being passed
21842183
assert received_context is not None
21852184
assert received_context.request_url is None
21862185
assert received_context.request_headers is None
@@ -2206,7 +2205,7 @@ async def bad_resolver(context):
22062205

22072206

22082207
# =============================================================================
2209-
# Requirement 3: OIDC Metadata and JWKS Fetching Tests
2208+
# OIDC Metadata and JWKS Fetching Tests
22102209
# =============================================================================
22112210

22122211

@@ -2416,7 +2415,7 @@ async def test_jwks_cache_size_limit():
24162415
)
24172416

24182417
# Set small cache size for testing
2419-
client._cache_max_size = 3
2418+
client._cache_max_entries = 3
24202419

24212420
mock_jwks = {"keys": [{"kty": "RSA"}]}
24222421

@@ -2487,7 +2486,7 @@ async def test_metadata_cache_size_limit():
24872486
state_store=AsyncMock()
24882487
)
24892488

2490-
client._cache_max_size = 2
2489+
client._cache_max_entries = 2
24912490

24922491
async def mock_fetch(domain):
24932492
return {"issuer": f"https://{domain}/"}
@@ -2509,7 +2508,7 @@ async def mock_fetch(domain):
25092508

25102509

25112510
# =============================================================================
2512-
# Requirement 4: Issuer Validation Tests
2511+
# Issuer Validation Tests
25132512
# =============================================================================
25142513

25152514

@@ -2668,7 +2667,7 @@ async def test_normalize_domain_handles_different_schemes():
26682667

26692668

26702669
# =============================================================================
2671-
# Requirements 5-8: Domain-specific Session Management Tests
2670+
# MCD Tests : Domain-specific Session Management Tests
26722671
# =============================================================================
26732672

26742673

0 commit comments

Comments
 (0)