From 4e513e6cf0cc343c7a2af09aaa2dadcfd41f6aa9 Mon Sep 17 00:00:00 2001 From: cerman Date: Wed, 18 Feb 2026 10:01:02 +0100 Subject: [PATCH 1/2] fix: grammar improvements --- redshift_connector/plugin/ping_credentials_provider.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/redshift_connector/plugin/ping_credentials_provider.py b/redshift_connector/plugin/ping_credentials_provider.py index d9644dc..c88ccc7 100644 --- a/redshift_connector/plugin/ping_credentials_provider.py +++ b/redshift_connector/plugin/ping_credentials_provider.py @@ -68,11 +68,11 @@ def get_saml_assertion(self: "PingCredentialsProvider") -> str: _logger.debug(exec_msg) raise InterfaceError(exec_msg) from e except requests.exceptions.TooManyRedirects as e: - exec_msg = "A error occurred when requesting Ping IdP login page. Please verify connection properties are correct." + exec_msg = "An error occurred when requesting Ping IdP login page. Please verify connection properties are correct." _logger.debug(exec_msg) raise InterfaceError(exec_msg) from e except requests.exceptions.RequestException as e: - exec_msg = "A unknown error occurred when requesting Ping IdP login page. Please verify connection properties are correct." + exec_msg = "An unknown error occurred when requesting Ping IdP login page. Please verify connection properties are correct." _logger.debug(exec_msg) raise InterfaceError(exec_msg) from e @@ -180,7 +180,7 @@ def get_saml_assertion(self: "PingCredentialsProvider") -> str: assertion = inputtag.get("value") if assertion == "": - exec_msg = "Failed to retrieve SAMLAssertion. A input tag named SAMLResponse was not identified in the Ping IdP authentication response" + exec_msg = "Failed to retrieve SAMLAssertion. An input tag named SAMLResponse was not identified in the Ping IdP authentication response" _logger.debug(exec_msg) raise InterfaceError(exec_msg) From 3ed86c85fd6e3912bb2eaeea3dcf4d39183ea8b5 Mon Sep 17 00:00:00 2001 From: Jaroslav Cerman <56031501+antivirak@users.noreply.github.com> Date: Sat, 21 Mar 2026 11:37:16 +0100 Subject: [PATCH 2/2] fix: typo in comment --- redshift_connector/plugin/saml_credentials_provider.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/redshift_connector/plugin/saml_credentials_provider.py b/redshift_connector/plugin/saml_credentials_provider.py index 83cccbc..d89f31e 100644 --- a/redshift_connector/plugin/saml_credentials_provider.py +++ b/redshift_connector/plugin/saml_credentials_provider.py @@ -106,7 +106,7 @@ def refresh(self: "SamlCredentialsProvider") -> None: _logger.debug("decoded SAML assertion into xml format") soup = bs4.BeautifulSoup(doc, "xml") attrs = soup.findAll("Attribute") - # extract RoleArn adn PrincipleArn from SAML assertion + # extract RoleArn and PrincipleArn from SAML assertion role_pattern = re.compile(r"arn:aws:iam::\d*:role/\S+") provider_pattern = re.compile(r"arn:aws:iam::\d*:saml-provider/\S+") roles: typing.Dict[str, str] = {}