From a734c227022e656ddf1ed87a5254d2e825cb9a53 Mon Sep 17 00:00:00 2001 From: Alex Wang Date: Wed, 29 Oct 2025 15:06:38 -0700 Subject: [PATCH] fix(testing-sdk): remove duplicate store update, use invoke - remove duplicate store update when validating invocation response - use client.invoke instead of invoke20150331 --- src/aws_durable_execution_sdk_python_testing/executor.py | 2 -- src/aws_durable_execution_sdk_python_testing/invoker.py | 3 +-- tests/invoker_test.py | 6 +++--- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/aws_durable_execution_sdk_python_testing/executor.py b/src/aws_durable_execution_sdk_python_testing/executor.py index 1025ab09..729ae79b 100644 --- a/src/aws_durable_execution_sdk_python_testing/executor.py +++ b/src/aws_durable_execution_sdk_python_testing/executor.py @@ -602,7 +602,6 @@ def _validate_invocation_response_and_store( self._complete_workflow( execution_arn, result=None, error=response.error ) - self._store.save(execution) case InvocationStatus.SUCCEEDED: if response.error is not None: @@ -614,7 +613,6 @@ def _validate_invocation_response_and_store( self._complete_workflow( execution_arn, result=response.result, error=None ) - self._store.save(execution) case InvocationStatus.PENDING: if not execution.has_pending_operations(execution): diff --git a/src/aws_durable_execution_sdk_python_testing/invoker.py b/src/aws_durable_execution_sdk_python_testing/invoker.py index dfde61b4..5c5441c0 100644 --- a/src/aws_durable_execution_sdk_python_testing/invoker.py +++ b/src/aws_durable_execution_sdk_python_testing/invoker.py @@ -143,9 +143,8 @@ def invoke( function_name: str, input: DurableExecutionInvocationInput, ) -> DurableExecutionInvocationOutput: - # TODO: temporary method name pre-build - switch to `invoke` for final # TODO: wrap ResourceNotFoundException from lambda in ResourceNotFoundException from this lib - response = self.lambda_client.invoke20150331( + response = self.lambda_client.invoke( FunctionName=function_name, InvocationType="RequestResponse", # Synchronous invocation Payload=json.dumps(input.to_dict(), default=str), diff --git a/tests/invoker_test.py b/tests/invoker_test.py index 8a409733..9ab62164 100644 --- a/tests/invoker_test.py +++ b/tests/invoker_test.py @@ -162,7 +162,7 @@ def test_lambda_invoker_invoke_success(): {"Status": "SUCCEEDED", "Result": "lambda-result"} ).encode("utf-8") - lambda_client.invoke20150331.return_value = { + lambda_client.invoke.return_value = { "StatusCode": 200, "Payload": mock_payload, } @@ -183,7 +183,7 @@ def test_lambda_invoker_invoke_success(): assert result.result == "lambda-result" # Verify lambda client was called correctly - lambda_client.invoke20150331.assert_called_once_with( + lambda_client.invoke.assert_called_once_with( FunctionName="test-function", InvocationType="RequestResponse", Payload=json.dumps(input_data.to_dict(), default=str), @@ -196,7 +196,7 @@ def test_lambda_invoker_invoke_failure(): # Mock failed response mock_payload = Mock() - lambda_client.invoke20150331.return_value = { + lambda_client.invoke.return_value = { "StatusCode": 500, "Payload": mock_payload, }