Honor expect-100 disabling rather than turn it on from independent settings

[steveloughran]

Describe the bug

#6828 now always enables 100-expect continue if cross-region is true.

if someone configures the client with expectContinueEnabled(false) then I expect expect-continue to not be set, even if that causes problems elsewhere. What I do not expect is something trying to be helpful by removing the ability for me to control http client behavior.

we will probably now have to modify the S3A connector to log once at WARN that the setting is going to be ignored if cross-region is enabled. joy

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

setting expectContinueEnabled(false) to disable expect continue

Current Behavior

setting expectContinueEnabled(false) mostly disables expect continue

Reproduction Steps

I'm commenting on recent pr

Possible Solution

No response

Additional Information/Context

No response

AWS Java SDK version used

HEAD

JDK version used

n/a

Operating System and version

n/a

[dagnir]

Hi @steveloughran, apologies if this came as surprising behavior. Did this negatively affect application behavior? Would it help if the SDK itself logs a message (at DEBUG), that the setting if false is being ignored?