-
Notifications
You must be signed in to change notification settings - Fork 265
feat: replace eager submodule imports with lazy loading #5110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dgandhi62
wants to merge
18
commits into
main
Choose a base branch
from
python-import-planning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
01f9be7
chore: regenerate test snapshots for updated fixture packages
dgandhi62 d71f24e
feat: add flow
dgandhi62 62b64f3
feat: update doc
dgandhi62 60de6a3
chore: update docs
dgandhi62 3f576e0
feat(python): replace eager submodule imports with PEP 562 lazy loading
dgandhi62 b41c4e5
chore: update gitignore
dgandhi62 2349a50
chore: update gitignore
dgandhi62 0cb34c8
fix: revert unrelated rosetta translation drift in non-Python snapshots
dgandhi62 4363e3c
chore: fix linters
dgandhi62 f121dd5
chore: remove md
dgandhi62 423c863
chore: temp files for understanding
dgandhi62 e9daeb9
fix(python): resolve pyright errors for PEP 562 lazy imports
dgandhi62 7a069d3
fix(python): resolve pyright and runtime failures for lazy imports
dgandhi62 6f66974
chore: add issue rcomments to lazy imports fixes
dgandhi62 0a38e74
chore: update snapshot
dgandhi62 466bedc
chore: fix pretier
dgandhi62 2bcfd91
chore: rebase branch
dgandhi62 ced5b7f
chore: remove .kiro and docs from branch, keep locally
dgandhi62 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I don't think jsii FQNs map cleanly onto Python import paths like this.
Pretty sure that the author of a jsii module can map whatever submodule they want to whatever Python module path. Plus, there types-in-types, and the last parts of the FQN might not be modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's an interesting question: CAN we deterministically find a Python type given a jsii FQN? (All the information should be in the assembly)
Because if we can, we can fully get rid of the registering-types-by-fqns-on-startup business that we have going on here!