From 097361d32d8bd79b0765c33c4f163e8cc37f6de8 Mon Sep 17 00:00:00 2001 From: Skjalf <47818697+Nyeriah@users.noreply.github.com> Date: Fri, 13 Mar 2026 18:47:17 -0300 Subject: [PATCH 1/2] docs: add text output section to C++ code standards Co-Authored-By: Claude Opus 4.6 --- docs/cpp-code-standards.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/cpp-code-standards.md b/docs/cpp-code-standards.md index b6ccdaba..0528dcca 100644 --- a/docs/cpp-code-standards.md +++ b/docs/cpp-code-standards.md @@ -329,3 +329,11 @@ All Header files should contain header guards #endif // MY_HEADER_H ``` + +### Text Output + +All script text output must use [acore_string](acore_string) whenever possible (e.g., command handlers, script messages). + +When adding new strings, localization must be provided for all available languages. + +**Tip:** You may use AI to assist with translating localization strings. From 7413c318b687085b96503b3ca90359b7fdaa9da8 Mon Sep 17 00:00:00 2001 From: Andrew <47818697+Nyeriah@users.noreply.github.com> Date: Fri, 13 Mar 2026 19:01:35 -0300 Subject: [PATCH 2/2] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- docs/cpp-code-standards.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/cpp-code-standards.md b/docs/cpp-code-standards.md index 0528dcca..28e4c084 100644 --- a/docs/cpp-code-standards.md +++ b/docs/cpp-code-standards.md @@ -332,7 +332,9 @@ All Header files should contain header guards ### Text Output -All script text output must use [acore_string](acore_string) whenever possible (e.g., command handlers, script messages). +All C++ script/system/command text output must use [acore_string](acore_string) whenever possible (e.g., ChatHandler messages, script system messages). + +NPC dialog, emotes, and other in-game text that is managed via database text systems (such as `creature_text`, `broadcast_text`, etc.) should continue to use those systems instead of `acore_string`. When adding new strings, localization must be provided for all available languages.