Skip to content
This repository was archived by the owner on Jul 21, 2023. It is now read-only.
This repository was archived by the owner on Jul 21, 2023. It is now read-only.

Add helpful details if commits.txt has dead commit hashes #4

@wturnerharris

Description

@wturnerharris

Issue occurred during Zupa Noma (PayWhirl -> reCharge) project.

$ npm run development

> zupa-noma@1.0.0 development /Users/user/Sites/zupa-noma
> brrl -d -e development


Proxy target set at https://zupa-noma-dev.myshopify.com
Compiling assets.. This could take a few moments
(node:66249) UnhandledPromiseRejectionWarning: fatal: bad object 8f2357061072669954108fff96842be184800b95

(node:66249) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:66249) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

This is a result of an uncaught exception due to unexpected behavior. The commits.txt contained two commit hashes that were not relevant to the project. This can happen if the file was ported from another project or if the commits were invalidated due to force push. Either way I was able to confirm that the deployment process continued without issue after commenting out L32. Understandably, this should be returning the diff'd files to reduce overhead of pushing all files rather than changed ones. After adding a common commit hash to the commits.txt and removing the others, the deployment command succeeded.

I recommend adding a catch or condition to indicate to the user of the CLI that the commits.txt file is bad or add a process to wipe it out and start again or find a common commit hash that does exist in the file.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions