Skip to content

Fix for arangodb 3.3 - rely on JSON.parse() instead of string parsing#8

Open
voondo wants to merge 1 commit into
baslr:masterfrom
voondo:3-3-fixes
Open

Fix for arangodb 3.3 - rely on JSON.parse() instead of string parsing#8
voondo wants to merge 1 commit into
baslr:masterfrom
voondo:3-3-fixes

Conversation

@voondo
Copy link
Copy Markdown

@voondo voondo commented May 9, 2018

Although arangochair works fine with arangodb 3.1, I had errors with 3.3. It seems the format changed a bit and the current string parser fails.

Here is a fix relying on JSON.parse() instead of parsing the string which seems more robust against format changes.

@voondo voondo changed the title Fixes for 3.3 - rely on JSON.parse() instead of string parsing Fix for arangodb 3.3 - rely on JSON.parse() instead of string parsing May 9, 2018
@yerboogieman
Copy link
Copy Markdown

Hi @voondo, my PR entitled "Emit separate events for inserts and updates" also has code to use JSON.parse() instead of relying on index-based string parsing. Perhaps we could merge our pull requests into one somehow so they do not conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants