Safety dialog: Improve how high-risk permissions are displayed

[bertob]

Currently you can have cases where there's "can acquire arbitrary permissions" next to "no XYZ access". These two statements are obviously in contradiction, either the app can acquire any permissions or it can't.

Proposal:

• When a high-risk permission overrides other permissions, we upgrade those other rows to the highest possible risk state (e.g. in this case No User Device Access -> User Device Access)
• If arbitrary permissions are enabled, show a row for each possible type of permission, even if it's not individually mentioned in the manifest (e.g. full DBus access and the like)
• Because the risk goes up as you acquire more permissions (e.g. camera or file access is more dangerous if you also have network access), make all permission icons red if arbitrary permissons/X11/etc are enabled. Verified and Free Software would remain green since they're unrelated.
• Hide duplicated permissions: If the app has full file system access, there's no point showing 10 random additional specific folders it also has separate access to, it just makes the list harder to parse

[AlexanderVanhee]

I agree that we should improve how "arbitrary permissions" are shown, but overwriting the full permission list when "arbitrary permissions" appears might be a bad idea. Just because an app can technically override its own permissions doesn't mean that’s the developer’s intent.

I think it would make more sense to have a page that explains what "arbitrary permissions" mean to the user in a similar fashion to the "High Risk" dialog and with a button at the bottom to view the permissions explicitly set by the developer. That would then show the current page we have here.

[bertob]

Interesting, yeah. I like the idea of showing an overview with actual capabilities (can do anything), but mentioning that this is maybe for technical reasons and have a way to see the exact intentions of the developer and linking to a full list on a subpage. Finding the right language may be tricky though, because we also don't want to give people a feeling of false security.